Bug 19520 - WebKit incorrectly accepts hidden as the value of outline-style
Summary: WebKit incorrectly accepts hidden as the value of outline-style
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Robert Blaut
URL: http://tc.labs.opera.com/css/ui/outli...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-12 08:38 PDT by Anthony Ricaud
Modified: 2008-06-24 00:19 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch for the issue (15.60 KB, patch)
2008-06-12 15:08 PDT, Robert Blaut
no flags Details | Formatted Diff | Diff
updated patch with text only test case (5.95 KB, patch)
2008-06-12 23:03 PDT, Robert Blaut
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ricaud 2008-06-12 08:38:46 PDT
outline-style: hidden is illegal but WebKit renders it.

http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines
The 'outline-style' property accepts the same values as 'border-style', except that 'hidden' is not a legal outline style.
Comment 1 Robert Blaut 2008-06-12 15:08:12 PDT
Created attachment 21665 [details]
Proposed patch for the issue
Comment 2 Darin Adler 2008-06-12 22:04:26 PDT
Comment on attachment 21665 [details]
Proposed patch for the issue

The regression test could be made a text-only test by using getComputedStyle, which I think would be better.

r=me
Comment 3 Robert Blaut 2008-06-12 22:23:58 PDT
You are (In reply to comment #2)
> (From update of attachment 21665 [details] [edit])
> The regression test could be made a text-only test by using getComputedStyle,
> which I think would be better.

You're absolutely right :) I'm working on it now. Updated patch will come really soon.  For now I clear the review flag. 
Comment 4 Robert Blaut 2008-06-12 23:03:50 PDT
Created attachment 21675 [details]
updated patch with text only test case
Comment 5 Darin Adler 2008-06-13 14:01:30 PDT
Comment on attachment 21675 [details]
updated patch with text only test case

r=me
Comment 6 Mark Rowe (bdash) 2008-06-22 17:59:14 PDT
Landed in r34732.