Bug 195136 - Web Inspector: Canvas: change tests to not print out dataURLs
Summary: Web Inspector: Canvas: change tests to not print out dataURLs
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2019-02-27 17:26 PST by Devin Rousso
Modified: 2019-02-28 14:01 PST (History)
5 users (show)

See Also:

Patch (47.43 KB, patch)
2019-02-27 17:27 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (47.40 KB, patch)
2019-02-28 09:55 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-27 17:26:08 PST
There's no reason to print the exact dataURL, especially when the test isn't actually testing the content (e.g. the recording tests care more about the fact that content was sent, not necessarily what that content was).
Comment 1 Devin Rousso 2019-02-27 17:26:21 PST
Comment 2 Devin Rousso 2019-02-27 17:27:31 PST
Created attachment 363165 [details]
Comment 3 Matt Baker 2019-02-27 17:43:15 PST
Comment on attachment 363165 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=363165&action=review

r=me, nice change.

> LayoutTests/inspector/canvas/requestContent-2d.html:28
> +            .then(({content}) => InspectorTest.expectGreaterThan(content.length, "data:image/png;base64,".length, "The content should not be empty."))

I'd drop the article from all of these: "Content should not be empty."

> LayoutTests/inspector/canvas/setShaderProgramHighlighted-expected.txt:12
> +PASS: Unhighlighting a shader program should draw differently.

Can this just be "Unhighlighting a shader program should change the content", or does the distinction matter?
Comment 4 Devin Rousso 2019-02-28 09:55:16 PST
Created attachment 363232 [details]
Comment 5 WebKit Commit Bot 2019-02-28 14:01:29 PST
Comment on attachment 363232 [details]

Clearing flags on attachment: 363232

Committed r242225: <https://trac.webkit.org/changeset/242225>
Comment 6 WebKit Commit Bot 2019-02-28 14:01:31 PST
All reviewed patches have been landed.  Closing bug.