Bug 19513 - Fix access-control-origin tests
Summary: Fix access-control-origin tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-12 01:06 PDT by Adam Barth
Modified: 2008-06-12 03:57 PDT (History)
1 user (show)

See Also:

Attachments
first attempt (2.60 KB, patch)
2008-06-12 01:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
second attempt (1.21 KB, patch)
2008-06-12 01:19 PDT, Adam Barth 		mjs: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2008-06-12 01:06:27 PDT 
I broke them when I added the data url test in r34504.  I think the issue is the result is getting cached and the test is seeing the response from the other test.
Comment 1 Adam Barth 2008-06-12 01:08:34 PDT 
Created attachment 21655 [details]
first attempt

I can't reproduce this on my machine, but this should bust through the cache, if that's the issue.
Comment 2 Adam Barth 2008-06-12 01:19:04 PDT 
Created attachment 21656 [details]
second attempt

As Maciej suggests, using the Cache-Control: no-cache header is a better way to prevent caching.
Comment 3 Maciej Stachowiak 2008-06-12 01:20:11 PDT 
Comment on attachment 21656 [details]
second attempt

r=me
Comment 4 Adam Barth 2008-06-12 03:57:59 PDT 
Turns out we needed no-store in the Cache-Control header as well.