Bug 195129 – REGRESSION(r241586:r241590): [GTK] Accessibility tests in need of rebase

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alicia Boya García]

Failing since r241586:r241590:

accessibility/image-link.html
accessibility/image-map2.html
accessibility/lists.html
accessibility/math-multiscript-attributes.html
accessibility/roles-exposed.html
accessibility/table-attributes.html
accessibility/table-cell-spans.html
accessibility/table-cells.html
accessibility/table-one-cell.html
accessibility/table-sections.html
accessibility/table-with-rules.html
accessibility/transformed-element.html
accessibility/gtk/object-attributes.html

Most diffs are just a difference in precision and may just need a rebase, e.g:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/image-link-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/image-link-actual.txt
@@ -6,8 +6,8 @@
 AXRole: AXLink
 AXParent: AXSection
 AXChildren: 1
-AXPosition: { 8.000000, 99.000000 }
-AXSize: { 280.000000, 214.000000 }
+AXPosition: { 8.00000, 99.0000 }
+AXSize: { 280.000, 214.000 }
 AXTitle: Delicious cake
 AXDescription: 
 AXValue: <obj>
@@ -27,8 +27,8 @@
 AXRole: AXImage
 AXParent: AXLink: Delicious cake
 AXChildren: 0
-AXPosition: { 8.000000, 100.000000 }
-AXSize: { 280.000000, 210.000000 }
+AXPosition: { 8.00000, 100.000 }
+AXSize: { 280.000, 210.000 }
 AXTitle: Delicious cake
 AXDescription: 
 AXFocusable: 0

While other look more fishy:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/roles-exposed-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/roles-exposed-actual.txt
@@ -80,7 +80,7 @@
       AXRole: AXLabel
       
 footer
-      AXRole: AXFooter
+      AXRole: AXLandmarkContentInfo
       
 form
       AXRole: AXForm

[Alicia Boya García]

accessibility/gtk/xml-roles-exposed.html is also failing in a similar way, whose solution may just be a rebase.

@@ -25,8 +25,8 @@
 AXRole: AXDialog
 AXParent: AXWebArea
 AXChildren: 0
-AXPosition: { 0.000000, 0.000000 }
-AXSize: { 0.000000, 0.000000 }
+AXPosition:  { 0.00000, 0.00000 }
+AXSize: { 0.00000, 0.00000 }
 AXTitle: 
 AXDescription: 
 AXValue:

[Joanmarie Diggs]

> While other look more fishy:
>  footer
> -      AXRole: AXFooter
> +      AXRole: AXLandmarkContentInfo

That would be a bug fix. It, too, just needs a rebase.

[Joanmarie Diggs]

Created attachment 365204 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365204 [details]
Patch

Clearing flags on attachment: 365204

Committed r243167: <https://trac.webkit.org/changeset/243167>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.