Bug 195128 - [ContentChangeObserver] Move WKSetObservedContentChange logic to ContentChangeObserver class.
Summary: [ContentChangeObserver] Move WKSetObservedContentChange logic to ContentChang...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-27 16:35 PST by zalan
Modified: 2019-02-27 20:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.99 KB, patch)
2019-02-27 16:45 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (33.74 KB, patch)
2019-02-27 19:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-27 16:35:06 PST 
ssia
Comment 1 zalan 2019-02-27 16:45:55 PST 
Created attachment 363156 [details]
Patch

Will update the patch with the rdar number
Comment 2 Radar WebKit Bug Importer 2019-02-27 16:51:06 PST 
<rdar://problem/48456752>
Comment 3 Simon Fraser (smfr) 2019-02-27 16:58:39 PST 
Comment on attachment 363156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363156&action=review

Want to do the .mm -> .cpp in this patch?

> Source/WebCore/page/ios/ContentChangeObserver.mm:225
> +    // We've already have a definite answer.

We've have? We have or We've had or We've received
Comment 4 zalan 2019-02-27 19:46:00 PST 
Created attachment 363185 [details]
Patch
Comment 5 WebKit Commit Bot 2019-02-27 20:39:27 PST 
Comment on attachment 363185 [details]
Patch

Clearing flags on attachment: 363185

Committed r242190: <https://trac.webkit.org/changeset/242190>
Comment 6 WebKit Commit Bot 2019-02-27 20:39:29 PST 
All reviewed patches have been landed.  Closing bug.