RESOLVED FIXED195128
[ContentChangeObserver] Move WKSetObservedContentChange logic to ContentChangeObserver class. 
https://bugs.webkit.org/show_bug.cgi?id=195128
Summary [ContentChangeObserver] Move WKSetObservedContentChange logic to ContentChang...
alan
Reported 2019-02-27 16:35:06 PST
ssia
Attachments
Patch (8.99 KB, patch)
2019-02-27 16:45 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (33.74 KB, patch)
2019-02-27 19:46 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2019-02-27 16:45:55 PST
Created attachment 363156 [details] Patch Will update the patch with the rdar number
Radar WebKit Bug Importer
Comment 2 2019-02-27 16:51:06 PST
<rdar://problem/48456752>
Simon Fraser (smfr)
Comment 3 2019-02-27 16:58:39 PST
Comment on attachment 363156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363156&action=review Want to do the .mm -> .cpp in this patch? > Source/WebCore/page/ios/ContentChangeObserver.mm:225 > + // We've already have a definite answer. We've have? We have or We've had or We've received
alan
Comment 4 2019-02-27 19:46:00 PST
Created attachment 363185 [details] Patch
WebKit Commit Bot
Comment 5 2019-02-27 20:39:27 PST
Comment on attachment 363185 [details] Patch Clearing flags on attachment: 363185 Committed r242190: <https://trac.webkit.org/changeset/242190>
WebKit Commit Bot
Comment 6 2019-02-27 20:39:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.