Bug 195127 – The parser is failing to record the token location of new in new.target.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

<rdar://problem/39645578>

[Mark Lam]

Created attachment 363152 [details]
proposed patch.

[Yusuke Suzuki]

Comment on attachment 363152 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363152&action=review

r=me with suggestion.

> Source/JavaScriptCore/parser/Parser.cpp:4678
> +    JSTokenLocation lastNewTokenlocation;

"l" in "location" seems lower case.

> Source/JavaScriptCore/parser/Parser.cpp:4682
> +            lastNewTokenlocation = currentLocation;

Why not making this `lastNewTokenLocation = tokenLocation()` and remove `currentLocation`?

[Mark Lam]

Created attachment 363177 [details]
proposed patch.

Updated with feedback from Yusuke and Saam.  Let's try this on the EWS first.

[Yusuke Suzuki]

Comment on attachment 363177 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363177&action=review

r=me

> Source/JavaScriptCore/parser/Parser.cpp:-4734
> -                JSTokenLocation location(tokenLocation());

If it is not difficult, can we have a test for this?

[Mark Lam]

Comment on attachment 363177 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363177&action=review

Thanks for the review.

>> Source/JavaScriptCore/parser/Parser.cpp:-4734
>> -                JSTokenLocation location(tokenLocation());
> 
> If it is not difficult, can we have a test for this?

I'm not sure how to check for this.  So, I'll wait until we have time later to develop some infrastructure for such tests.

[Mark Lam]

Landed in r242193: <http://trac.webkit.org/r242193>.