Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction

[David Quesada]

When allowing a navigation action, a client might want to know whether WebKit will forcibly convert the load to a download due to a 'download' anchor attribute.

[Radar WebKit Bug Importer]

<rdar://problem/48450302>

[David Quesada]

Created attachment 363135 [details]
Patch

[Alex Christensen]

This needs more motivation justification.  What do you intend to do with this information?  What are we planning to do that we have never done before that this would enable?

[Alex Christensen]

Comment on attachment 363135 [details]
Patch

We will need this, and maybe something else, too.  We'll figure that out in another patch.

r- because I think this should have a test.

[David Quesada]

Created attachment 363162 [details]
Patch v2

[David Quesada]

Created attachment 363172 [details]
Patch v3

Try to fix the broken EWS builds.

[David Quesada]

Created attachment 363173 [details]
Patch v4

[Alex Christensen]

Comment on attachment 363173 [details]
Patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=363173&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:97
> +    auto baseURL = adoptNS([[NSURL alloc] initWithString:@"https://example.com/index.html"]);

This is a little simpler:
[NSURL URLWithString:@"https://example.com/index.html"]

[David Quesada]

Created attachment 363264 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 363264 [details]
Patch for landing

Clearing flags on attachment: 363264

Committed r242236: <https://trac.webkit.org/changeset/242236>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.