RESOLVED FIXED 195113
Web Inspector: popover colors don't change when transitioning to/from dark mode 
https://bugs.webkit.org/show_bug.cgi?id=195113
Summary Web Inspector: popover colors don't change when transitioning to/from dark mode
Devin Rousso
Reported 2019-02-27 11:35:03 PST
# STEPS TO REPRODUCE: 1. inspect any page 2. find some CSS color in the Styles sidebar of the Elements tab 3. click the color swatch 4. go to System Preferences > General and change the appearance to Dark => the popover still has a light background
Attachments
Patch (2.11 KB, patch)
2019-02-27 11:50 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-27 11:35:40 PST
<rdar://problem/48444188>
Devin Rousso
Comment 2 2019-02-27 11:50:37 PST
Created attachment 363111 [details] Patch
WebKit Commit Bot
Comment 3 2019-02-27 12:13:21 PST
Comment on attachment 363111 [details] Patch Clearing flags on attachment: 363111 Committed r242144: <https://trac.webkit.org/changeset/242144>
WebKit Commit Bot
Comment 4 2019-02-27 12:13:22 PST
All reviewed patches have been landed. Closing bug.
Matt Baker
Comment 5 2019-02-27 13:45:21 PST
Comment on attachment 363111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363111&action=review > Source/WebInspectorUI/UserInterface/Views/Popover.js:587 > + this._prefersDarkColorSchemeMediaQueryList = window.matchMedia("(prefers-color-scheme: dark)"); Cool!
Note You need to log in before you can comment on or make changes to this bug.