Bug 195107 – Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap seems flaky. In http://ews-build.webkit-uat.org/#/builders/19/builds/1291, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed.

[Aakash Jain]

This test was added in https://trac.webkit.org/changeset/240818/webkit

[Chris Dumez]

Created attachment 363226 [details]
Patch

[EWS Watchlist]

Attachment 363226 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 363226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363226&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2788
> +    } while (clientWidth != expectedClientWidth);

Having a maximum number of tries would help us debug any future problems with this, turning a timeout into an eventual failure.  Right now the maximum is effectively 1, and this patch makes it infinite.  Somewhere between the two ought to be good.

[Chris Dumez]

Created attachment 363236 [details]
Patch

[EWS Watchlist]

Attachment 363236 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 363236 [details]
Patch

Clearing flags on attachment: 363236

Committed r242208: <https://trac.webkit.org/changeset/242208>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48481175>