Bug 195107 - Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
Summary: Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-27 10:41 PST by Aakash Jain
Modified: 2019-02-28 11:12 PST (History)
13 users (show)

See Also:


Attachments
Patch (4.61 KB, patch)
2019-02-28 09:02 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2019-02-28 10:24 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-27 10:41:42 PST
TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap seems flaky. In http://ews-build.webkit-uat.org/#/builders/19/builds/1291, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed.
Comment 1 Aakash Jain 2019-02-28 05:09:08 PST
This test was added in https://trac.webkit.org/changeset/240818/webkit
Comment 2 Chris Dumez 2019-02-28 09:02:41 PST
Created attachment 363226 [details]
Patch
Comment 3 EWS Watchlist 2019-02-28 09:05:08 PST
Attachment 363226 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2019-02-28 10:19:37 PST
Comment on attachment 363226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363226&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2788
> +    } while (clientWidth != expectedClientWidth);

Having a maximum number of tries would help us debug any future problems with this, turning a timeout into an eventual failure.  Right now the maximum is effectively 1, and this patch makes it infinite.  Somewhere between the two ought to be good.
Comment 5 Chris Dumez 2019-02-28 10:24:39 PST
Created attachment 363236 [details]
Patch
Comment 6 EWS Watchlist 2019-02-28 10:26:50 PST
Attachment 363236 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2768:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2019-02-28 10:52:01 PST
Comment on attachment 363236 [details]
Patch

Clearing flags on attachment: 363236

Committed r242208: <https://trac.webkit.org/changeset/242208>
Comment 8 WebKit Commit Bot 2019-02-28 10:52:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-02-28 11:12:25 PST
<rdar://problem/48481175>