RESOLVED FIXED Bug 195105
Web Inspector: Sources: breakpoints should be disabled when an audit is running 
https://bugs.webkit.org/show_bug.cgi?id=195105
Summary Web Inspector: Sources: breakpoints should be disabled when an audit is running
Devin Rousso
Reported 2019-02-27 10:13:05 PST
This hadn't yet been created when the first Sources patch was uploaded.
Attachments
Patch (9.77 KB, patch)
2019-02-27 10:45 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (9.78 KB, patch)
2019-03-02 12:11 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-27 10:30:01 PST
<rdar://problem/48441373>
Devin Rousso
Comment 2 2019-02-27 10:45:12 PST
Created attachment 363105 [details] Patch
Joseph Pecoraro
Comment 3 2019-03-02 01:39:08 PST
Comment on attachment 363105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663 > + let stopAuditButton = document.createElement("button"); In the Debugger tab this is a "a" not a "button". Why the change? > Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665 > + stopAuditButton.addEventListener("click", () => { Nit: Don't you prefer putting `event` in the param?
Devin Rousso
Comment 4 2019-03-02 12:09:08 PST
Comment on attachment 363105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review >> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663 >> + let stopAuditButton = document.createElement("button"); > > In the Debugger tab this is a "a" not a "button". Why the change? I prefer <button> over <a> in most cases. Using an <a> didn't feel as "obvious"/"actionable" as a <button>. The rest of the Sources navigation sidebar also follows this pattern (as well as the general "Clear Filters"). >> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665 >> + stopAuditButton.addEventListener("click", () => { > > Nit: Don't you prefer putting `event` in the param? Oops :P
Devin Rousso
Comment 5 2019-03-02 12:11:37 PST
Created attachment 363425 [details] Patch
WebKit Commit Bot
Comment 6 2019-03-02 12:50:14 PST
Comment on attachment 363425 [details] Patch Clearing flags on attachment: 363425 Committed r242315: <https://trac.webkit.org/changeset/242315>
WebKit Commit Bot
Comment 7 2019-03-02 12:50:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.