Bug 195105 - Web Inspector: Sources: breakpoints should be disabled when an audit is running
Summary: Web Inspector: Sources: breakpoints should be disabled when an audit is running
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-27 10:13 PST by Devin Rousso
Modified: 2019-03-02 12:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.77 KB, patch)
2019-02-27 10:45 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (9.78 KB, patch)
2019-03-02 12:11 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-27 10:13:05 PST
This hadn't yet been created when the first Sources patch was uploaded.
Comment 1 Radar WebKit Bug Importer 2019-02-27 10:30:01 PST
<rdar://problem/48441373>
Comment 2 Devin Rousso 2019-02-27 10:45:12 PST
Created attachment 363105 [details]
Patch
Comment 3 Joseph Pecoraro 2019-03-02 01:39:08 PST
Comment on attachment 363105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663
> +            let stopAuditButton = document.createElement("button");

In the Debugger tab this is a "a" not a "button". Why the change?

> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665
> +            stopAuditButton.addEventListener("click", () => {

Nit: Don't you prefer putting `event` in the param?
Comment 4 Devin Rousso 2019-03-02 12:09:08 PST
Comment on attachment 363105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363105&action=review

>> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1663
>> +            let stopAuditButton = document.createElement("button");
> 
> In the Debugger tab this is a "a" not a "button". Why the change?

I prefer <button> over <a> in most cases.  Using an <a> didn't feel as "obvious"/"actionable" as a <button>.  The rest of the Sources navigation sidebar also follows this pattern (as well as the general "Clear Filters").

>> Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js:1665
>> +            stopAuditButton.addEventListener("click", () => {
> 
> Nit: Don't you prefer putting `event` in the param?

Oops :P
Comment 5 Devin Rousso 2019-03-02 12:11:37 PST
Created attachment 363425 [details]
Patch
Comment 6 WebKit Commit Bot 2019-03-02 12:50:14 PST
Comment on attachment 363425 [details]
Patch

Clearing flags on attachment: 363425

Committed r242315: <https://trac.webkit.org/changeset/242315>
Comment 7 WebKit Commit Bot 2019-03-02 12:50:15 PST
All reviewed patches have been landed.  Closing bug.