Bug 195101 - Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled
Summary: Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-27 09:34 PST by Chris Dumez
Modified: 2019-02-27 11:03 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2019-02-27 09:55 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-02-27 09:34:28 PST 
Unable to log into chase.com on iPad when DeviceMotionEvent API is disabled.
Comment 1 Chris Dumez 2019-02-27 09:34:42 PST 
<rdar://problem/48423023>
Comment 2 Chris Dumez 2019-02-27 09:55:18 PST 
Created attachment 363097 [details]
Patch
Comment 3 Geoffrey Garen 2019-02-27 10:30:15 PST 
Comment on attachment 363097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review

r=me with one change

> Source/WebCore/page/DOMWindow.cpp:1894
> +    if (!isSameSecurityOriginAsMainFrame() || !isSecureContext())
> +        return;

Can you add a test for needsSiteSpecificQuirks here, so that website developers can disable the quirk when testing a fix?
Comment 4 Chris Dumez 2019-02-27 10:31:06 PST 
Comment on attachment 363097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363097&action=review

> Source/WebCore/ChangeLog:13
> +        Unfortunately, document()->settings().needsSiteSpecificQuirks() is false on iOS so I could not

See this line in the change log.
Comment 5 Geoffrey Garen 2019-02-27 10:34:23 PST 
Sad face.
Comment 6 WebKit Commit Bot 2019-02-27 11:03:27 PST 
Comment on attachment 363097 [details]
Patch

Clearing flags on attachment: 363097

Committed r242138: <https://trac.webkit.org/changeset/242138>
Comment 7 WebKit Commit Bot 2019-02-27 11:03:29 PST 
All reviewed patches have been landed.  Closing bug.