Bug 195087 – [ContentChangeObserver] Move style recalc handling from global to ContentChangeObserver class

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 363059 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/48425308>

[Tim Horton]

Comment on attachment 363059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363059&action=review

red patch

> Source/WebCore/page/ios/ContentChangeObserver.mm:185
> +    m_observingStyleRecalScheduling = true;

"Recal"?

> Source/WebCore/page/ios/ContentChangeObserver.mm:190
> +    m_observingStyleRecalScheduling = false;

"Recal"?

> Source/WebCore/page/ios/ContentChangeObserver.mm:195
> +    return m_observingStyleRecalScheduling;

"Recal"?

[zalan]

(In reply to Tim Horton from comment #3)
> Comment on attachment 363059 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363059&action=review
> 
> red patch
Happens when you make patches faster than you land them.

> 
> > Source/WebCore/page/ios/ContentChangeObserver.mm:185
> > +    m_observingStyleRecalScheduling = true;
> 
> "Recal"?
> 
> > Source/WebCore/page/ios/ContentChangeObserver.mm:190
> > +    m_observingStyleRecalScheduling = false;
> 
> "Recal"?
> 
> > Source/WebCore/page/ios/ContentChangeObserver.mm:195
> > +    return m_observingStyleRecalScheduling;
> 
> "Recal"?
Yeah, it's actually a thing ->

bool inStyleRecalc();
void scheduleStyleRecalc();
void unscheduleStyleRecalc();
bool hasPendingStyleRecalc() const;
void startTrackingStyleRecalcs(); (!even plural)
unsigned styleRecalcCount() const;
...

[Tim Horton]

(In reply to zalan from comment #4)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 363059 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=363059&action=review
> > 
> > red patch
> Happens when you make patches faster than you land them.
> 
> > 
> > > Source/WebCore/page/ios/ContentChangeObserver.mm:185
> > > +    m_observingStyleRecalScheduling = true;
> > 
> > "Recal"?
> > 
> > > Source/WebCore/page/ios/ContentChangeObserver.mm:190
> > > +    m_observingStyleRecalScheduling = false;
> > 
> > "Recal"?
> > 
> > > Source/WebCore/page/ios/ContentChangeObserver.mm:195
> > > +    return m_observingStyleRecalScheduling;
> > 
> > "Recal"?
> Yeah, it's actually a thing ->
> 
> bool inStyleRecalc();
> void scheduleStyleRecalc();
> void unscheduleStyleRecalc();
> bool hasPendingStyleRecalc() const;
> void startTrackingStyleRecalcs(); (!even plural)
> unsigned styleRecalcCount() const;
> ...
Those are recalc, not recal!

[zalan]

(In reply to Tim Horton from comment #5)
> (In reply to zalan from comment #4)
> > (In reply to Tim Horton from comment #3)
> > > Comment on attachment 363059 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=363059&action=review
> > > 
> > > red patch
> > Happens when you make patches faster than you land them.
> > 
> > > 
> > > > Source/WebCore/page/ios/ContentChangeObserver.mm:185
> > > > +    m_observingStyleRecalScheduling = true;
> > > 
> > > "Recal"?
> > > 
> > > > Source/WebCore/page/ios/ContentChangeObserver.mm:190
> > > > +    m_observingStyleRecalScheduling = false;
> > > 
> > > "Recal"?
> > > 
> > > > Source/WebCore/page/ios/ContentChangeObserver.mm:195
> > > > +    return m_observingStyleRecalScheduling;
> > > 
> > > "Recal"?
> > Yeah, it's actually a thing ->
> > 
> > bool inStyleRecalc();
> > void scheduleStyleRecalc();
> > void unscheduleStyleRecalc();
> > bool hasPendingStyleRecalc() const;
> > void startTrackingStyleRecalcs(); (!even plural)
> > unsigned styleRecalcCount() const;
> > ...
> Those are recalc, not recal!
lol

[zalan]

Created attachment 363136 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 363136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363136&action=review

> Source/WebCore/ChangeLog:8
> +        Add m_observingNextStyleRecalc/m_observingStyleRecalScheduling to ContentChangeObserver and move the related code over from WK functions.

m_observingStyleRecalcScheduling

[zalan]

Committed r242167: <https://trac.webkit.org/changeset/242167>