Bug 195081 - Web Inspector: Debugger: don't enable breakpoints when source location changes
Summary: Web Inspector: Debugger: don't enable breakpoints when source location changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-26 17:24 PST by Devin Rousso
Modified: 2019-03-02 12:32 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.54 KB, patch)
2019-02-26 17:30 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (2.57 KB, patch)
2019-02-26 17:30 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-26 17:24:34 PST
# STEPS TO REPRODUCE:
1. inspect any page with a minified script
2. pretty print the script
3. set a breakpoint on any line
4. disable breakpoints
5. close Web Inspector
6. open Web Inspector
 => breakpoints start out disabled, but become enabled once the script becomes pretty printed
Comment 1 Radar WebKit Bug Importer 2019-02-26 17:30:02 PST
<rdar://problem/48422701>
Comment 2 Devin Rousso 2019-02-26 17:30:12 PST
Created attachment 363044 [details]
Patch
Comment 3 Devin Rousso 2019-02-26 17:30:32 PST
Created attachment 363045 [details]
Patch
Comment 4 Joseph Pecoraro 2019-03-02 01:52:06 PST
Comment on attachment 363045 [details]
Patch

r=me Wow, good find!
Comment 5 WebKit Commit Bot 2019-03-02 12:32:17 PST
Comment on attachment 363045 [details]
Patch

Clearing flags on attachment: 363045

Committed r242314: <https://trac.webkit.org/changeset/242314>
Comment 6 WebKit Commit Bot 2019-03-02 12:32:18 PST
All reviewed patches have been landed.  Closing bug.