Bug 195060 - Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion
Summary: Web Inspector: Canvas: enabling auto-capture if the frame count is empty trig...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2019-02-26 11:42 PST by Devin Rousso
Modified: 2019-02-28 13:07 PST (History)
5 users (show)

See Also:

Patch (3.38 KB, patch)
2019-02-26 11:47 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-26 11:42:08 PST
1. inspect any page
2. go to the Canvas tab
3. delete all text inside the auto-capture frame count <input> (make sure the checkbox is unchecked)
4. click the checkbox
 => the <input> is empty and has the placeholder "null"
Comment 1 Devin Rousso 2019-02-26 11:47:16 PST
Created attachment 362999 [details]
Comment 2 Radar WebKit Bug Importer 2019-02-26 11:47:34 PST
Comment 3 Matt Baker 2019-02-28 12:41:17 PST
Comment on attachment 362999 [details]

r=me, nice refactor. It makes much more sense to check this._recordingAutoCaptureFrameCountInputElementValue separately from setting the frame count and updating the label.
Comment 4 WebKit Commit Bot 2019-02-28 13:07:05 PST
Comment on attachment 362999 [details]

Clearing flags on attachment: 362999

Committed r242217: <https://trac.webkit.org/changeset/242217>
Comment 5 WebKit Commit Bot 2019-02-28 13:07:06 PST
All reviewed patches have been landed.  Closing bug.