Bug 195060 - Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion
Summary: Web Inspector: Canvas: enabling auto-capture if the frame count is empty trig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-26 11:42 PST by Devin Rousso
Modified: 2019-02-28 13:07 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.38 KB, patch)
2019-02-26 11:47 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-26 11:42:08 PST 
# STEPS TO REPRODUCE:
1. inspect any page
2. go to the Canvas tab
3. delete all text inside the auto-capture frame count <input> (make sure the checkbox is unchecked)
4. click the checkbox
 => the <input> is empty and has the placeholder "null"
Comment 1 Devin Rousso 2019-02-26 11:47:16 PST 
Created attachment 362999 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-02-26 11:47:34 PST 
<rdar://problem/48408669>
Comment 3 Matt Baker 2019-02-28 12:41:17 PST 
Comment on attachment 362999 [details]
Patch

r=me, nice refactor. It makes much more sense to check this._recordingAutoCaptureFrameCountInputElementValue separately from setting the frame count and updating the label.
Comment 4 WebKit Commit Bot 2019-02-28 13:07:05 PST 
Comment on attachment 362999 [details]
Patch

Clearing flags on attachment: 362999

Committed r242217: <https://trac.webkit.org/changeset/242217>
Comment 5 WebKit Commit Bot 2019-02-28 13:07:06 PST 
All reviewed patches have been landed.  Closing bug.