Bug 195049 – Fix warnings on ARM and MIPS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dominik Inführ]

Fix warnings on ARM and MIPS

[Dominik Inführ]

Created attachment 362986 [details]
Patch

[Mark Lam]

Comment on attachment 362986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362986&action=review

r=me with fix.

> Source/JavaScriptCore/tools/JSDollarVM.cpp:1464
> +            candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());

Let's use bitwise_cast here too.

[Saam Barati]

Comment on attachment 362986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362986&action=review

>> Source/JavaScriptCore/tools/JSDollarVM.cpp:1464
>> +            candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());
> 
> Let's use bitwise_cast here too.

Why?
My preference of casting is:
1. static_cast
2. bitwise_cast
3. reinterpret_cast

[Mark Lam]

Comment on attachment 362986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362986&action=review

>>> Source/JavaScriptCore/tools/JSDollarVM.cpp:1464
>>> +            candidateCodeBlock = static_cast<CodeBlock*>(value.asCell());
>> 
>> Let's use bitwise_cast here too.
> 
> Why?
> My preference of casting is:
> 1. static_cast
> 2. bitwise_cast
> 3. reinterpret_cast

I just wasn't thinking correctly.  I guess static_cast does a compile time type check, and hence, is preferable to bitwise_cast which only does a size check.  I withdraw my comment.

[WebKit Commit Bot]

Comment on attachment 362986 [details]
Patch

Clearing flags on attachment: 362986

Committed r242109: <https://trac.webkit.org/changeset/242109>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48415918>

[Guillaume Emont]

*** Bug 188598 has been marked as a duplicate of this bug. ***