After https://bugs.webkit.org/show_bug.cgi?id=194961, ews-app's build table also include builder_display_name. So, buildbot should include builder_display_name in the build event data (e.g.: build-start/end events) it send to ews-app.
Created attachment 362981 [details] Proposed patch
Attachment 362981 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/events.py:112: [Events.buildStarted] Instance of 'Events' has no 'master' member [pylint/E1101] [5] ERROR: Tools/BuildSlaveSupport/ews-build/events.py:139: [Events.buildFinished] Instance of 'Events' has no 'master' member [pylint/E1101] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them?
> any reason to separate them? I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch.
Comment on attachment 362981 [details] Proposed patch Clearing flags on attachment: 362981 Committed r242185: <https://trac.webkit.org/changeset/242185>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48460180>