RESOLVED FIXED Bug 195045
[ews-build] Buildbot should include builder_display_name in the build events 
https://bugs.webkit.org/show_bug.cgi?id=195045
Summary [ews-build] Buildbot should include builder_display_name in the build events
Aakash Jain
Reported 2019-02-26 06:41:57 PST
After https://bugs.webkit.org/show_bug.cgi?id=194961, ews-app's build table also include builder_display_name. So, buildbot should include builder_display_name in the build event data (e.g.: build-start/end events) it send to ews-app.
Attachments
Proposed patch (2.74 KB, patch)
2019-02-26 06:48 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-02-26 06:48:22 PST
Created attachment 362981 [details] Proposed patch
EWS Watchlist
Comment 2 2019-02-26 06:50:43 PST Comment hidden (obsolete)
Jonathan Bedard
Comment 3 2019-02-26 10:13:25 PST
This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them?
Aakash Jain
Comment 4 2019-02-26 10:38:09 PST
> any reason to separate them? I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch.
WebKit Commit Bot
Comment 5 2019-02-27 17:47:09 PST
Comment on attachment 362981 [details] Proposed patch Clearing flags on attachment: 362981 Committed r242185: <https://trac.webkit.org/changeset/242185>
WebKit Commit Bot
Comment 6 2019-02-27 17:47:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-02-27 18:51:36 PST
<rdar://problem/48460180>
Note You need to log in before you can comment on or make changes to this bug.