Bug 195045 - [ews-build] Buildbot should include builder_display_name in the build events
Summary: [ews-build] Buildbot should include builder_display_name in the build events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-26 06:41 PST by Aakash Jain
Modified: 2019-02-27 18:51 PST (History)
11 users (show)

See Also:


Attachments
Proposed patch (2.74 KB, patch)
2019-02-26 06:48 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-26 06:41:57 PST
After https://bugs.webkit.org/show_bug.cgi?id=194961, ews-app's build table also include builder_display_name. So, buildbot should include builder_display_name in the build event data (e.g.: build-start/end events) it send to ews-app.
Comment 1 Aakash Jain 2019-02-26 06:48:22 PST
Created attachment 362981 [details]
Proposed patch
Comment 2 Build Bot 2019-02-26 06:50:43 PST Comment hidden (obsolete)
Comment 3 Jonathan Bedard 2019-02-26 10:13:25 PST
This almost feels like this should have been contained in <https://bugs.webkit.org/show_bug.cgi?id=194961>, any reason to separate them?
Comment 4 Aakash Jain 2019-02-26 10:38:09 PST
> any reason to separate them?
I have been making smaller patches to make them easier to review. Previous reviewers found it easier to review multiple smaller patches as compared to a large patch.
Comment 5 WebKit Commit Bot 2019-02-27 17:47:09 PST
Comment on attachment 362981 [details]
Proposed patch

Clearing flags on attachment: 362981

Committed r242185: <https://trac.webkit.org/changeset/242185>
Comment 6 WebKit Commit Bot 2019-02-27 17:47:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-02-27 18:51:36 PST
<rdar://problem/48460180>