Bug 195022 - [JSC] Make Intl fields lazily-allocated
Summary: [JSC] Make Intl fields lazily-allocated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-25 16:05 PST by Yusuke Suzuki
Modified: 2019-02-25 18:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (25.22 KB, patch)
2019-02-25 16:08 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (23.70 KB, patch)
2019-02-25 16:12 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-25 16:05:11 PST
[JSC] Make Intl fields lazily-allocated
Comment 1 Yusuke Suzuki 2019-02-25 16:08:55 PST
Created attachment 362938 [details]
Patch
Comment 2 Yusuke Suzuki 2019-02-25 16:12:08 PST
Created attachment 362941 [details]
Patch
Comment 3 Mark Lam 2019-02-25 16:47:10 PST
Comment on attachment 362941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362941&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +        1. Make IntlObject fields including Intl.Collator lazily-alllocated because we already removed direct references from JS builtins to these constructors (@Collator etc.).

/alllocated/allocated/.
Comment 4 Yusuke Suzuki 2019-02-25 17:05:35 PST
Comment on attachment 362941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362941&action=review

>> Source/JavaScriptCore/ChangeLog:10
>> +        1. Make IntlObject fields including Intl.Collator lazily-alllocated because we already removed direct references from JS builtins to these constructors (@Collator etc.).
> 
> /alllocated/allocated/.

Oops, thanks.
Comment 5 Yusuke Suzuki 2019-02-25 18:13:25 PST
Committed r242064: <https://trac.webkit.org/changeset/242064>
Comment 6 Radar WebKit Bug Importer 2019-02-25 18:33:58 PST
<rdar://problem/48387136>