Bug 195020 - [JSC] Add SPI to configure number of GC markers dynamically
Summary: [JSC] Add SPI to configure number of GC markers dynamically
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on: 195013
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-25 15:13 PST by Yusuke Suzuki
Modified: 2019-02-25 15:32 PST (History)
9 users (show)

See Also:


Attachments
Patch (19.52 KB, patch)
2019-02-25 15:21 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (19.71 KB, patch)
2019-02-25 15:32 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-25 15:13:51 PST
...
Comment 1 Yusuke Suzuki 2019-02-25 15:21:59 PST
Created attachment 362934 [details]
Patch
Comment 2 EWS Watchlist 2019-02-25 15:24:11 PST
Attachment 362934 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/HeapHelperPool.cpp:43:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WTF/wtf/ParallelHelperPool.cpp:78:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/API/tests/testapi.mm:565:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/API/tests/testapi.mm:566:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/API/tests/testapi.mm:567:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2019-02-25 15:32:50 PST
Created attachment 362936 [details]
Patch