Bug 195008 – Support Pointer Events on macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antoine Quint]

We currently only support Pointer Events on iOS, we need to make them work with the mouse on macOS too.

[Antoine Quint]

<rdar://problem/47454419>

[Antoine Quint]

Created attachment 362911 [details]
EWS run, not for review

[EWS Watchlist]

Attachment 362911 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antoine Quint]

Created attachment 362992 [details]
Patch

[EWS Watchlist]

Comment on attachment 362992 [details]
Patch

Attachment 362992 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11291951

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 362997 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 362992 [details]
Patch

Attachment 362992 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11292065

New failing tests:
pointerevents/mouse/pointerdown-prevent-default.html
pointerevents/mouse/pointer-events-before-mouse-events.html
pointerevents/mouse/pointer-capture.html
pointerevents/mouse/over-enter-out-leave.html

[EWS Watchlist]

Created attachment 362998 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Antoine Quint]

The failures on the WK1 bots are due to two things:

1. the Pointer Events runtime flag wasn't set to true in DumpRenderTree
2. the window.eventSender APIs behave differently in WK1 and make the tests fail (see webkit.org/b/195098)

[Antoine Quint]

Created attachment 363092 [details]
Patch

[Antoine Quint]

The new patch ensures DRT runs with the Pointer Events flag set to true, just like WKTR, and fixes crashers in debug mode due to the default pointerId being to set to 0.

[WebKit Commit Bot]

Comment on attachment 363092 [details]
Patch

Clearing flags on attachment: 363092

Committed r242137: <https://trac.webkit.org/changeset/242137>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.