Bug 195001 - [WPE] Bump WPEBackend-fdo requirement to API version 1.0
Summary: [WPE] Bump WPEBackend-fdo requirement to API version 1.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-25 04:21 PST by Adrian Perez
Modified: 2019-02-25 13:48 PST (History)
8 users (show)

See Also:


Attachments
Patch (4.91 KB, patch)
2019-02-25 04:24 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch v2 (6.01 KB, patch)
2019-02-25 04:47 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch v3 (15.10 KB, patch)
2019-02-25 07:09 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.46 MB, application/zip)
2019-02-25 09:07 PST, Build Bot
no flags Details
Patch for landing (15.12 KB, patch)
2019-02-25 13:21 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2019-02-25 04:21:14 PST
This is needed to accommodate to the changes in WPEBackend-fdo
for its upcoming 1.2.x release series.

Note that the patch should be merged to 2.24 release branch, too.
Comment 1 Adrian Perez 2019-02-25 04:24:48 PST
Created attachment 362892 [details]
Patch
Comment 2 Philippe Normand 2019-02-25 04:32:48 PST
Comment on attachment 362892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362892&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:83
>  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
> -    wpe_loader_init("libWPEBackend-fdo-0.1.so");
> +    wpe_loader_init("libWPEBackend-fdo-1.0.so");
>  #endif
>  
> +    // TODO: This may return false, but it is unclear what could be
> +    //       done here to handle failure and notify accordingly.
>      wpe_fdo_initialize_for_egl_display(m_eglDisplay);

I think this should now move to WPEQtViewBackend::create(), especially considering the TODO.
Comment 3 Carlos Garcia Campos 2019-02-25 04:33:59 PST
Comment on attachment 362892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362892&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:77
>  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)

We should remove all these ifdefs now that we depend on newer version.

> Source/cmake/FindWPEBackend-fdo.cmake:32
> -pkg_check_modules(PC_WPEBACKEND_FDO QUIET wpebackend-fdo-0.1)
> +pkg_check_modules(PC_WPEBACKEND_FDO QUIET wpebackend-fdo-1.0)

I would also change the OptionsWPE file to require the new version explicitly.
Comment 4 Adrian Perez 2019-02-25 04:47:41 PST
Created attachment 362893 [details]
Patch v2


Addresses the changes requested by Philippe and Carlos Garcia.
Comment 5 Carlos Garcia Campos 2019-02-25 05:25:33 PST
Comment on attachment 362893 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=362893&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:77
>  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)

We should remove all these ifdefs now that we depend on newer version.
Comment 6 Adrian Perez 2019-02-25 06:29:35 PST
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 362893 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362893&action=review
> 
> > Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:77
> >  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
> 
> We should remove all these ifdefs now that we depend on newer version.

That's a good point, I'll update the patch momentarily :)
Comment 7 Adrian Perez 2019-02-25 07:09:13 PST
Created attachment 362900 [details]
Patch v3


Removes usage of the WPE_BACKEND_CHECK_VERSION() macro.
Comment 8 Build Bot 2019-02-25 09:07:52 PST
Comment on attachment 362900 [details]
Patch v3

Attachment 362900 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11278162

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
Comment 9 Build Bot 2019-02-25 09:07:53 PST
Created attachment 362905 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 10 Adrian Perez 2019-02-25 13:08:51 PST
(In reply to Build Bot from comment #9)
> Created attachment 362905 [details]
> Archive of layout-test-results from ews122 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

The patch only touches code specific to the WPE port, so this
iOS failure must be unrelated; therefore I'm going ahead and
setting cq+ to this =)
Comment 11 Adrian Perez 2019-02-25 13:13:43 PST
Comment on attachment 362900 [details]
Patch v3

Setting cq- back... Let's wait to have the following build fix
in WPEBackend-fdo before updating the JHBuild moduleset:

  https://github.com/Igalia/WPEBackend-fdo/pull/35
Comment 12 Adrian Perez 2019-02-25 13:21:37 PST
Created attachment 362921 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2019-02-25 13:48:31 PST
Comment on attachment 362921 [details]
Patch for landing

Clearing flags on attachment: 362921

Committed r242055: <https://trac.webkit.org/changeset/242055>
Comment 14 WebKit Commit Bot 2019-02-25 13:48:33 PST
All reviewed patches have been landed.  Closing bug.