Bug 195001 – [WPE] Bump WPEBackend-fdo requirement to API version 1.0

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Adrian Perez]

This is needed to accommodate to the changes in WPEBackend-fdo
for its upcoming 1.2.x release series.

Note that the patch should be merged to 2.24 release branch, too.

[Adrian Perez]

Created attachment 362892 [details]
Patch

[Philippe Normand]

Comment on attachment 362892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362892&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:83
>  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
> -    wpe_loader_init("libWPEBackend-fdo-0.1.so");
> +    wpe_loader_init("libWPEBackend-fdo-1.0.so");
>  #endif
>  
> +    // TODO: This may return false, but it is unclear what could be
> +    //       done here to handle failure and notify accordingly.
>      wpe_fdo_initialize_for_egl_display(m_eglDisplay);

I think this should now move to WPEQtViewBackend::create(), especially considering the TODO.

[Carlos Garcia Campos]

Comment on attachment 362892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362892&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:77
>  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)

We should remove all these ifdefs now that we depend on newer version.

> Source/cmake/FindWPEBackend-fdo.cmake:32
> -pkg_check_modules(PC_WPEBACKEND_FDO QUIET wpebackend-fdo-0.1)
> +pkg_check_modules(PC_WPEBACKEND_FDO QUIET wpebackend-fdo-1.0)

I would also change the OptionsWPE file to require the new version explicitly.

[Adrian Perez]

Created attachment 362893 [details]
Patch v2


Addresses the changes requested by Philippe and Carlos Garcia.

[Carlos Garcia Campos]

Comment on attachment 362893 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=362893&action=review

> Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:77
>  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)

We should remove all these ifdefs now that we depend on newer version.

[Adrian Perez]

(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 362893 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362893&action=review
> 
> > Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:77
> >  #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
> 
> We should remove all these ifdefs now that we depend on newer version.

That's a good point, I'll update the patch momentarily :)

[Adrian Perez]

Created attachment 362900 [details]
Patch v3


Removes usage of the WPE_BACKEND_CHECK_VERSION() macro.

[EWS Watchlist]

Comment on attachment 362900 [details]
Patch v3

Attachment 362900 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11278162

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

[EWS Watchlist]

Created attachment 362905 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Adrian Perez]

(In reply to Build Bot from comment #9)
> Created attachment 362905 [details]
> Archive of layout-test-results from ews122 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

The patch only touches code specific to the WPE port, so this
iOS failure must be unrelated; therefore I'm going ahead and
setting cq+ to this =)

[Adrian Perez]

Comment on attachment 362900 [details]
Patch v3

Setting cq- back... Let's wait to have the following build fix
in WPEBackend-fdo before updating the JHBuild moduleset:

  https://github.com/Igalia/WPEBackend-fdo/pull/35

[Adrian Perez]

Created attachment 362921 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 362921 [details]
Patch for landing

Clearing flags on attachment: 362921

Committed r242055: <https://trac.webkit.org/changeset/242055>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.