Bug 194995 - [iOS] Adjust initial scale zooming heuristics when changing view scale
Summary: [iOS] Adjust initial scale zooming heuristics when changing view scale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-24 16:54 PST by Wenson Hsieh
Modified: 2019-02-25 16:20 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.65 KB, patch)
2019-02-24 17:16 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-02-24 16:54:31 PST
Currently, we only zoom to the new initial scale iff we're exactly at initial scale before changing the view scale. This was done so that if a user zoomed in really far and then increased the view scale, we wouldn't end up zooming out as a result.

Per conversation with Tim and Yongjun, we should consider changing the heuristics here, such that:
• If the view scale is increasing and the new initial scale is greater than the current scale, zoom to initial scale.
• Likewise, if the view scale is decreasing and the new initial scale is less than the current scale, zoom to initial scale.
Comment 1 Wenson Hsieh 2019-02-24 17:16:46 PST
Created attachment 362869 [details]
Patch
Comment 2 WebKit Commit Bot 2019-02-25 16:19:56 PST
Comment on attachment 362869 [details]
Patch

Clearing flags on attachment: 362869

Committed r242059: <https://trac.webkit.org/changeset/242059>
Comment 3 WebKit Commit Bot 2019-02-25 16:19:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-02-25 16:20:54 PST
<rdar://problem/48382246>