Bug 194987 - [ContentChangeObserver] Move observing logic from DOMTimer to ContentChangeObserver
Summary: [ContentChangeObserver] Move observing logic from DOMTimer to ContentChangeOb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-23 21:36 PST by zalan
Modified: 2019-02-26 15:52 PST (History)
7 users (show)

See Also:

Attachments
Patch (13.89 KB, patch)
2019-02-23 21:41 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.61 KB, patch)
2019-02-25 14:01 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.04 KB, patch)
2019-02-25 14:15 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.02 KB, patch)
2019-02-25 15:06 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-02-23 21:36:36 PST 
That's where the logic belongs.
Comment 1 Radar WebKit Bug Importer 2019-02-23 21:37:05 PST 
<rdar://problem/48342910>
Comment 2 zalan 2019-02-23 21:41:05 PST 
Created attachment 362852 [details]
Patch
Comment 3 zalan 2019-02-25 14:01:56 PST 
Created attachment 362926 [details]
Patch
Comment 4 zalan 2019-02-25 14:15:40 PST 
Created attachment 362927 [details]
Patch
Comment 5 zalan 2019-02-25 15:06:33 PST 
Created attachment 362931 [details]
Patch
Comment 6 zalan 2019-02-25 15:11:25 PST 
Committed r242058: <https://trac.webkit.org/changeset/242058>
Comment 7 Truitt Savell 2019-02-26 15:48:13 PST 
Looks like the changes in https://trac.webkit.org/changeset/242058/webkit

caused fast/dom/Window/timer-null-script-execution-context.html to crash constantly on iOS.

History:
fast/dom/Window/timer-null-script-execution-context.html

reproduced with command:
run-webkit-tests fast/dom/Window/timer-null-script-execution-context.html --ios-simulator

test crashes on r242058 but not on r242057.

The test is crashing with no crash log available.
Comment 8 zalan 2019-02-26 15:52:47 PST 
(In reply to Truitt Savell from comment #7)
> Looks like the changes in https://trac.webkit.org/changeset/242058/webkit
> 
> caused fast/dom/Window/timer-null-script-execution-context.html to crash
> constantly on iOS.
> 
> History:
> fast/dom/Window/timer-null-script-execution-context.html
> 
> reproduced with command:
> run-webkit-tests fast/dom/Window/timer-null-script-execution-context.html
> --ios-simulator
> 
> test crashes on r242058 but not on r242057.
> 
> The test is crashing with no crash log available.
Thanks. Looking into it.