RESOLVED FIXED Bug 194987
[ContentChangeObserver] Move observing logic from DOMTimer to ContentChangeObserver 
https://bugs.webkit.org/show_bug.cgi?id=194987
Summary [ContentChangeObserver] Move observing logic from DOMTimer to ContentChangeOb...
zalan
Reported 2019-02-23 21:36:36 PST
That's where the logic belongs.
Attachments
Patch (13.89 KB, patch)
2019-02-23 21:41 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (14.61 KB, patch)
2019-02-25 14:01 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (15.04 KB, patch)
2019-02-25 14:15 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (15.02 KB, patch)
2019-02-25 15:06 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-23 21:37:05 PST
<rdar://problem/48342910>
zalan
Comment 2 2019-02-23 21:41:05 PST
Created attachment 362852 [details] Patch
zalan
Comment 3 2019-02-25 14:01:56 PST
Created attachment 362926 [details] Patch
zalan
Comment 4 2019-02-25 14:15:40 PST
Created attachment 362927 [details] Patch
zalan
Comment 5 2019-02-25 15:06:33 PST
Created attachment 362931 [details] Patch
zalan
Comment 6 2019-02-25 15:11:25 PST
Committed r242058: <https://trac.webkit.org/changeset/242058>
Truitt Savell
Comment 7 2019-02-26 15:48:13 PST
Looks like the changes in https://trac.webkit.org/changeset/242058/webkit caused fast/dom/Window/timer-null-script-execution-context.html to crash constantly on iOS. History: fast/dom/Window/timer-null-script-execution-context.html reproduced with command: run-webkit-tests fast/dom/Window/timer-null-script-execution-context.html --ios-simulator test crashes on r242058 but not on r242057. The test is crashing with no crash log available.
zalan
Comment 8 2019-02-26 15:52:47 PST
(In reply to Truitt Savell from comment #7) > Looks like the changes in https://trac.webkit.org/changeset/242058/webkit > > caused fast/dom/Window/timer-null-script-execution-context.html to crash > constantly on iOS. > > History: > fast/dom/Window/timer-null-script-execution-context.html > > reproduced with command: > run-webkit-tests fast/dom/Window/timer-null-script-execution-context.html > --ios-simulator > > test crashes on r242058 but not on r242057. > > The test is crashing with no crash log available. Thanks. Looking into it.
Note You need to log in before you can comment on or make changes to this bug.