Bug 194976 - [JSC] Drop direct references to Intl constructors by rewriting Intl JS builtins in C++
Summary: [JSC] Drop direct references to Intl constructors by rewriting Intl JS builti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-23 02:38 PST by Yusuke Suzuki
Modified: 2019-02-25 10:37 PST (History)
6 users (show)

See Also:

Attachments
Patch (28.80 KB, patch)
2019-02-23 02:45 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-highsierra (2.45 MB, application/zip)
2019-02-23 04:01 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.57 MB, application/zip)
2019-02-23 04:14 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (2.07 MB, application/zip)
2019-02-23 04:41 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (10.27 MB, application/zip)
2019-02-23 04:58 PST, EWS Watchlist 		no flags Details
Patch (31.87 KB, patch)
2019-02-23 14:47 PST, Yusuke Suzuki 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-23 02:38:37 PST 
[JSC] Drop direct references to Intl constructors by rewriting Intl JS builtins in C++
Comment 1 Yusuke Suzuki 2019-02-23 02:45:07 PST 
Created attachment 362821 [details]
Patch
Comment 2 EWS Watchlist 2019-02-23 04:01:06 PST 
Comment on attachment 362821 [details]
Patch

Attachment 362821 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11259192

New failing tests:
js/string-localeCompare.html
js/dom/string-prototype-properties.html
js/number-toLocaleString.html
Comment 3 EWS Watchlist 2019-02-23 04:01:08 PST 
Created attachment 362822 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 EWS Watchlist 2019-02-23 04:14:18 PST 
Comment on attachment 362821 [details]
Patch

Attachment 362821 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11259212

New failing tests:
js/string-localeCompare.html
js/dom/string-prototype-properties.html
js/number-toLocaleString.html
Comment 5 EWS Watchlist 2019-02-23 04:14:19 PST 
Created attachment 362823 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 EWS Watchlist 2019-02-23 04:41:35 PST 
Comment on attachment 362821 [details]
Patch

Attachment 362821 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11259254

New failing tests:
js/string-localeCompare.html
js/dom/string-prototype-properties.html
js/number-toLocaleString.html
Comment 7 EWS Watchlist 2019-02-23 04:41:37 PST 
Created attachment 362825 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 8 EWS Watchlist 2019-02-23 04:58:03 PST 
Comment on attachment 362821 [details]
Patch

Attachment 362821 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11259286

New failing tests:
js/string-localeCompare.html
js/dom/string-prototype-properties.html
js/number-toLocaleString.html
Comment 9 EWS Watchlist 2019-02-23 04:58:04 PST 
Created attachment 362826 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 10 EWS Watchlist 2019-02-23 05:23:47 PST 
Comment on attachment 362821 [details]
Patch

Attachment 362821 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/11259273

New failing tests:
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-llint
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-no-ftl
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-ftl
jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-no-llint
Comment 11 Yusuke Suzuki 2019-02-23 14:47:04 PST 
Created attachment 362837 [details]
Patch
Comment 12 Michael Saboff 2019-02-25 10:15:37 PST 
Comment on attachment 362837 [details]
Patch

r=me
Comment 13 Yusuke Suzuki 2019-02-25 10:32:27 PST 
Committed r242047: <https://trac.webkit.org/changeset/242047>
Comment 14 Radar WebKit Bug Importer 2019-02-25 10:37:40 PST 
<rdar://problem/48368171>