RESOLVED FIXED Bug 194976
[JSC] Drop direct references to Intl constructors by rewriting Intl JS builtins in C++ 
https://bugs.webkit.org/show_bug.cgi?id=194976
Summary [JSC] Drop direct references to Intl constructors by rewriting Intl JS builti...
Yusuke Suzuki
Reported 2019-02-23 02:38:37 PST
[JSC] Drop direct references to Intl constructors by rewriting Intl JS builtins in C++
Attachments
Patch (28.80 KB, patch)
2019-02-23 02:45 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-highsierra (2.45 MB, application/zip)
2019-02-23 04:01 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.57 MB, application/zip)
2019-02-23 04:14 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews112 for mac-highsierra (2.07 MB, application/zip)
2019-02-23 04:41 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (10.27 MB, application/zip)
2019-02-23 04:58 PST, EWS Watchlist 		no flags
Details
Patch (31.87 KB, patch)
2019-02-23 14:47 PST, Yusuke Suzuki 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-02-23 02:45:07 PST
Created attachment 362821 [details] Patch
EWS Watchlist
Comment 2 2019-02-23 04:01:06 PST
Comment on attachment 362821 [details] Patch Attachment 362821 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11259192 New failing tests: js/string-localeCompare.html js/dom/string-prototype-properties.html js/number-toLocaleString.html
EWS Watchlist
Comment 3 2019-02-23 04:01:08 PST
Created attachment 362822 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 4 2019-02-23 04:14:18 PST
Comment on attachment 362821 [details] Patch Attachment 362821 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11259212 New failing tests: js/string-localeCompare.html js/dom/string-prototype-properties.html js/number-toLocaleString.html
EWS Watchlist
Comment 5 2019-02-23 04:14:19 PST
Created attachment 362823 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 6 2019-02-23 04:41:35 PST
Comment on attachment 362821 [details] Patch Attachment 362821 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11259254 New failing tests: js/string-localeCompare.html js/dom/string-prototype-properties.html js/number-toLocaleString.html
EWS Watchlist
Comment 7 2019-02-23 04:41:37 PST
Created attachment 362825 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 8 2019-02-23 04:58:03 PST
Comment on attachment 362821 [details] Patch Attachment 362821 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11259286 New failing tests: js/string-localeCompare.html js/dom/string-prototype-properties.html js/number-toLocaleString.html
EWS Watchlist
Comment 9 2019-02-23 04:58:04 PST
Created attachment 362826 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 10 2019-02-23 05:23:47 PST
Comment on attachment 362821 [details] Patch Attachment 362821 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/11259273 New failing tests: jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-ftl-no-cjit jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-no-ftl jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-ftl-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-ftl-no-cjit jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-ftl-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/number-toLocaleString.js.layout-no-ftl jsc-layout-tests.yaml/js/script-tests/string-localeCompare.js.layout-no-llint
Yusuke Suzuki
Comment 11 2019-02-23 14:47:04 PST
Created attachment 362837 [details] Patch
Michael Saboff
Comment 12 2019-02-25 10:15:37 PST
Comment on attachment 362837 [details] Patch r=me
Yusuke Suzuki
Comment 13 2019-02-25 10:32:27 PST
Committed r242047: <https://trac.webkit.org/changeset/242047>
Radar WebKit Bug Importer
Comment 14 2019-02-25 10:37:40 PST
<rdar://problem/48368171>
Note You need to log in before you can comment on or make changes to this bug.