WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194975
[JSC] Lazily create sentinel Map and Set buckets
https://bugs.webkit.org/show_bug.cgi?id=194975
Summary
[JSC] Lazily create sentinel Map and Set buckets
Yusuke Suzuki
Reported
2019-02-23 01:12:35 PST
[JSC] Lazily create sentinel Map and Set buckets
Attachments
Patch
(16.17 KB, patch)
2019-02-23 01:14 PST
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(16.94 KB, patch)
2019-02-23 01:20 PST
,
Yusuke Suzuki
saam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2019-02-23 01:14:58 PST
Created
attachment 362819
[details]
Patch
Yusuke Suzuki
Comment 2
2019-02-23 01:20:00 PST
Created
attachment 362820
[details]
Patch
Saam Barati
Comment 3
2019-02-24 15:18:11 PST
Comment on
attachment 362820
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=362820&action=review
r=me
> Source/JavaScriptCore/runtime/VM.cpp:404 > + // Eagerly initialize constant cells if concurrent compiler can touch.
“if” => “since”. “touch” => “access them”
> Source/JavaScriptCore/runtime/VM.h:572 > + JSCell* sentinelSetBucketSlow();
Should be private
> Source/JavaScriptCore/runtime/VM.h:580 > + JSCell* sentinelMapBucketSlow();
Ditto
Saam Barati
Comment 4
2019-02-24 15:19:11 PST
Comment on
attachment 362820
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=362820&action=review
>> Source/JavaScriptCore/runtime/VM.cpp:404 >> + // Eagerly initialize constant cells if concurrent compiler can touch. > > “if” => “since”. “touch” => “access them”
Oops, I meant: “if” => “since the”
Yusuke Suzuki
Comment 5
2019-02-24 18:14:50 PST
Comment on
attachment 362820
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=362820&action=review
Thanks, fixed.
>>> Source/JavaScriptCore/runtime/VM.cpp:404 >>> + // Eagerly initialize constant cells if concurrent compiler can touch. >> >> “if” => “since”. “touch” => “access them” > > Oops, I meant: > “if” => “since the”
Fixed.
>> Source/JavaScriptCore/runtime/VM.h:572 >> + JSCell* sentinelSetBucketSlow(); > > Should be private
Fixed.
>> Source/JavaScriptCore/runtime/VM.h:580 >> + JSCell* sentinelMapBucketSlow(); > > Ditto
Fixed.
Yusuke Suzuki
Comment 6
2019-02-24 18:17:39 PST
Committed
r242015
: <
https://trac.webkit.org/changeset/242015
>
Radar WebKit Bug Importer
Comment 7
2019-02-24 18:31:21 PST
<
rdar://problem/48349543
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug