[JSC] Lazily create sentinel Map and Set buckets
Created attachment 362819 [details] Patch
Created attachment 362820 [details] Patch
Comment on attachment 362820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review r=me > Source/JavaScriptCore/runtime/VM.cpp:404 > + // Eagerly initialize constant cells if concurrent compiler can touch. “if” => “since”. “touch” => “access them” > Source/JavaScriptCore/runtime/VM.h:572 > + JSCell* sentinelSetBucketSlow(); Should be private > Source/JavaScriptCore/runtime/VM.h:580 > + JSCell* sentinelMapBucketSlow(); Ditto
Comment on attachment 362820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review >> Source/JavaScriptCore/runtime/VM.cpp:404 >> + // Eagerly initialize constant cells if concurrent compiler can touch. > > “if” => “since”. “touch” => “access them” Oops, I meant: “if” => “since the”
Comment on attachment 362820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review Thanks, fixed. >>> Source/JavaScriptCore/runtime/VM.cpp:404 >>> + // Eagerly initialize constant cells if concurrent compiler can touch. >> >> “if” => “since”. “touch” => “access them” > > Oops, I meant: > “if” => “since the” Fixed. >> Source/JavaScriptCore/runtime/VM.h:572 >> + JSCell* sentinelSetBucketSlow(); > > Should be private Fixed. >> Source/JavaScriptCore/runtime/VM.h:580 >> + JSCell* sentinelMapBucketSlow(); > > Ditto Fixed.
Committed r242015: <https://trac.webkit.org/changeset/242015>
<rdar://problem/48349543>