Bug 194975 - [JSC] Lazily create sentinel Map and Set buckets
Summary: [JSC] Lazily create sentinel Map and Set buckets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-23 01:12 PST by Yusuke Suzuki
Modified: 2019-02-24 18:31 PST (History)
6 users (show)

See Also:


Attachments
Patch (16.17 KB, patch)
2019-02-23 01:14 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (16.94 KB, patch)
2019-02-23 01:20 PST, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-23 01:12:35 PST
[JSC] Lazily create sentinel Map and Set buckets
Comment 1 Yusuke Suzuki 2019-02-23 01:14:58 PST
Created attachment 362819 [details]
Patch
Comment 2 Yusuke Suzuki 2019-02-23 01:20:00 PST
Created attachment 362820 [details]
Patch
Comment 3 Saam Barati 2019-02-24 15:18:11 PST
Comment on attachment 362820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review

r=me

> Source/JavaScriptCore/runtime/VM.cpp:404
> +    // Eagerly initialize constant cells if concurrent compiler can touch.

“if” => “since”. “touch” => “access them”

> Source/JavaScriptCore/runtime/VM.h:572
> +    JSCell* sentinelSetBucketSlow();

Should be private

> Source/JavaScriptCore/runtime/VM.h:580
> +    JSCell* sentinelMapBucketSlow();

Ditto
Comment 4 Saam Barati 2019-02-24 15:19:11 PST
Comment on attachment 362820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review

>> Source/JavaScriptCore/runtime/VM.cpp:404
>> +    // Eagerly initialize constant cells if concurrent compiler can touch.
> 
> “if” => “since”. “touch” => “access them”

Oops, I meant:
“if” => “since the”
Comment 5 Yusuke Suzuki 2019-02-24 18:14:50 PST
Comment on attachment 362820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362820&action=review

Thanks, fixed.

>>> Source/JavaScriptCore/runtime/VM.cpp:404
>>> +    // Eagerly initialize constant cells if concurrent compiler can touch.
>> 
>> “if” => “since”. “touch” => “access them”
> 
> Oops, I meant:
> “if” => “since the”

Fixed.

>> Source/JavaScriptCore/runtime/VM.h:572
>> +    JSCell* sentinelSetBucketSlow();
> 
> Should be private

Fixed.

>> Source/JavaScriptCore/runtime/VM.h:580
>> +    JSCell* sentinelMapBucketSlow();
> 
> Ditto

Fixed.
Comment 6 Yusuke Suzuki 2019-02-24 18:17:39 PST
Committed r242015: <https://trac.webkit.org/changeset/242015>
Comment 7 Radar WebKit Bug Importer 2019-02-24 18:31:21 PST
<rdar://problem/48349543>