Bug 194969 - Give DrawingAreas their own identifiers
Summary: Give DrawingAreas their own identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-22 16:55 PST by Chris Dumez
Modified: 2019-02-23 19:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (40.90 KB, patch)
2019-02-22 16:59 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Follow-up fix for API tests (4.42 KB, patch)
2019-02-23 17:47 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-02-22 16:55:33 PST 
Give DrawingAreas their own identifiers instead of using the pageID. It will make the IPC more robust now that a WebPageProxy can have several drawing areas with PSON.
Comment 1 Chris Dumez 2019-02-22 16:56:00 PST 
<rdar://problem/48154508>
Comment 2 Chris Dumez 2019-02-22 16:59:41 PST 
Created attachment 362794 [details]
Patch
Comment 3 Chris Dumez 2019-02-22 17:00:27 PST 
Needs more testing, especially on macOS. May need a little more work to build everywhere.
Comment 4 Geoffrey Garen 2019-02-22 20:42:36 PST 
Comment on attachment 362794 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2019-02-22 21:30:25 PST 
Comment on attachment 362794 [details]
Patch

Clearing flags on attachment: 362794

Committed r241988: <https://trac.webkit.org/changeset/241988>
Comment 6 WebKit Commit Bot 2019-02-22 21:30:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2019-02-23 17:47:07 PST 
Reopening to attach new patch.
Comment 8 Chris Dumez 2019-02-23 17:47:09 PST 
Created attachment 362842 [details]
Follow-up fix for API tests
Comment 9 WebKit Commit Bot 2019-02-23 19:03:15 PST 
Comment on attachment 362842 [details]
Follow-up fix for API tests

Clearing flags on attachment: 362842

Committed r242010: <https://trac.webkit.org/changeset/242010>
Comment 10 WebKit Commit Bot 2019-02-23 19:03:17 PST 
All reviewed patches have been landed.  Closing bug.