Bug 194962 – Add an exception check and some assertions in StringPrototype.cpp.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

<rdar://problem/48013416>

[Mark Lam]

Created attachment 362775 [details]
proposed patch.

[Yusuke Suzuki]

Comment on attachment 362775 [details]
proposed patch.

r=me

[Saam Barati]

Comment on attachment 362775 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=362775&action=review

> Source/WTF/wtf/CheckedArithmetic.h:545
> +inline bool observesOverflows() { return true; }

constexpr?

I'd also name this "ovservesOverflow"

> Source/WTF/wtf/CheckedArithmetic.h:548
> +inline bool observesOverflows<AssertNoOverflow>() { return !ASSERT_DISABLED; }

constexpr?

[Mark Lam]

Thanks for the reviews.

(In reply to Saam Barati from comment #3)
> Comment on attachment 362775 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362775&action=review
> 
> > Source/WTF/wtf/CheckedArithmetic.h:545
> > +inline bool observesOverflows() { return true; }
> 
> constexpr?
> 
> I'd also name this "ovservesOverflow"
> 
> > Source/WTF/wtf/CheckedArithmetic.h:548
> > +inline bool observesOverflows<AssertNoOverflow>() { return !ASSERT_DISABLED; }
> 
> constexpr?

I'll apply these changes.

[Mark Lam]

Created attachment 362784 [details]
patch for landing w/ build fixes.

Let's see if the EWS likes this better.

[Mark Lam]

Created attachment 362790 [details]
patch for landing.

Let's try the EWS again with a different fix.

[Mark Lam]

Created attachment 362800 [details]
patch for landing (uploaded to hopefully tickle the EWS bots into running).

[Mark Lam]

Created attachment 362805 [details]
patch for landing.

The issue does not repro on my local builds.  So let's try another speculative build fix.

[Mark Lam]

Created attachment 362807 [details]
patch for landing: 6th time's the charm.

[Mark Lam]

Landed in r241991: <http://trac.webkit.org/r241991>.