Bug 194959 - Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
Summary: Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-22 13:22 PST by Aakash Jain
Modified: 2019-02-27 20:11 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2019-02-27 17:24 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (1.67 KB, patch)
2019-02-27 19:04 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-22 13:22:47 PST
TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories seems flaky. In https://ews-build.webkit-uat.org/#/builders/19/builds/1115, the test Failed in run-api-tests step. However, in the immediately next retry step (re-run-api-tests), it passed.
Comment 1 youenn fablet 2019-02-27 17:24:27 PST
Created attachment 363163 [details]
Patch
Comment 2 Chris Dumez 2019-02-27 18:11:19 PST
Comment on attachment 363163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363163&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1376
> +        TestWebKitAPI::Util::spinRunLoop(1);

1 second seems excessive, I would suggest 0.1
Comment 3 youenn fablet 2019-02-27 19:04:51 PST
Created attachment 363179 [details]
Patch for landing
Comment 4 youenn fablet 2019-02-27 19:05:18 PST
(In reply to Chris Dumez from comment #2)
> Comment on attachment 363163 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=363163&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1376
> > +        TestWebKitAPI::Util::spinRunLoop(1);
> 
> 1 second seems excessive, I would suggest 0.1

Done
Comment 5 WebKit Commit Bot 2019-02-27 19:42:50 PST
Comment on attachment 363179 [details]
Patch for landing

Clearing flags on attachment: 363179

Committed r242188: <https://trac.webkit.org/changeset/242188>
Comment 6 WebKit Commit Bot 2019-02-27 19:42:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-02-27 20:11:15 PST
<rdar://problem/48461500>