RESOLVED FIXED Bug 194950
Web Inspector: Canvas: if no auto-capture value is specified, don't force the input to have "0" as the value 
https://bugs.webkit.org/show_bug.cgi?id=194950
Summary Web Inspector: Canvas: if no auto-capture value is specified, don't force the...
Devin Rousso
Reported 2019-02-22 10:33:21 PST
# STEPS TO REPRODUCE 1. inspect any page 2. go to the Canvas tab 3. delete the existing text from the "[ ] Record <input> frame(s)" input => the <input> automatically sets the content to "0" if there is no other content (e.g. empty) When typing after this, there's now a leading "0" (e.g. "01").
Attachments
Patch (6.61 KB, patch)
2019-02-22 10:42 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-02-22 10:33:32 PST
<rdar://problem/48276798>
Devin Rousso
Comment 2 2019-02-22 10:42:59 PST
Created attachment 362730 [details] Patch
Joseph Pecoraro
Comment 3 2019-02-25 23:30:11 PST
Comment on attachment 362730 [details] Patch rs=me, Seems a little messy to use a private getter/setter here instead of just methods.
Devin Rousso
Comment 4 2019-02-25 23:45:42 PST
Comment on attachment 362730 [details] Patch (In reply to Joseph Pecoraro from comment #3) > rs=me, Seems a little messy to use a private getter/setter here instead of just methods. I intentionally named the getter/setter so that it would be almost the same as if we used the <input> directly (`_recordingAutoCaptureFrameCountInputElementValue` vs `_recordingAutoCaptureFrameCountInputElement.value`).
WebKit Commit Bot
Comment 5 2019-02-26 00:11:43 PST
Comment on attachment 362730 [details] Patch Clearing flags on attachment: 362730 Committed r242079: <https://trac.webkit.org/changeset/242079>
WebKit Commit Bot
Comment 6 2019-02-26 00:11:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.