Bug 194950 - Web Inspector: Canvas: if no auto-capture value is specified, don't force the input to have "0" as the value
Summary: Web Inspector: Canvas: if no auto-capture value is specified, don't force the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasTab
  Show dependency tree / graph
 
Reported: 2019-02-22 10:33 PST by Devin Rousso
Modified: 2019-02-26 00:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.61 KB, patch)
2019-02-22 10:42 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-22 10:33:21 PST 
# STEPS TO REPRODUCE
1. inspect any page
2. go to the Canvas tab
3. delete the existing text from the "[ ] Record <input> frame(s)" input
 => the <input> automatically sets the content to "0" if there is no other content (e.g. empty)

When typing after this, there's now a leading "0" (e.g. "01").
Comment 1 Devin Rousso 2019-02-22 10:33:32 PST 
<rdar://problem/48276798>
Comment 2 Devin Rousso 2019-02-22 10:42:59 PST 
Created attachment 362730 [details]
Patch
Comment 3 Joseph Pecoraro 2019-02-25 23:30:11 PST 
Comment on attachment 362730 [details]
Patch

rs=me, Seems a little messy to use a private getter/setter here instead of just methods.
Comment 4 Devin Rousso 2019-02-25 23:45:42 PST 
Comment on attachment 362730 [details]
Patch

(In reply to Joseph Pecoraro from comment #3)
> rs=me, Seems a little messy to use a private getter/setter here instead of just methods.
I intentionally named the getter/setter so that it would be almost the same as if we used the <input> directly (`_recordingAutoCaptureFrameCountInputElementValue` vs `_recordingAutoCaptureFrameCountInputElement.value`).
Comment 5 WebKit Commit Bot 2019-02-26 00:11:43 PST 
Comment on attachment 362730 [details]
Patch

Clearing flags on attachment: 362730

Committed r242079: <https://trac.webkit.org/changeset/242079>
Comment 6 WebKit Commit Bot 2019-02-26 00:11:44 PST 
All reviewed patches have been landed.  Closing bug.