Bug 194937 - Avoid hashing CompactVariableEnvironment when decoding CompactVariableMap::Handle
Summary: Avoid hashing CompactVariableEnvironment when decoding CompactVariableMap::Ha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on: 194706
Blocks:
  Show dependency tree / graph
 
Reported: 2019-02-22 00:53 PST by Tadeu Zagallo
Modified: 2019-02-25 12:16 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2019-02-22 00:59 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch (3.01 KB, patch)
2019-02-25 10:16 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2019-02-22 00:53:55 PST 
Per Saam's suggestion in https://bugs.webkit.org/show_bug.cgi?id=194706, hashing the CompactVariableEnvironment is expensive and we could avoid it when decoding multiple handles to the same environment.
Comment 1 Tadeu Zagallo 2019-02-22 00:59:26 PST 
Created attachment 362705 [details]
Patch
Comment 2 Tadeu Zagallo 2019-02-25 10:16:54 PST 
Created attachment 362908 [details]
Patch

Rebase
Comment 3 Saam Barati 2019-02-25 11:27:52 PST 
Comment on attachment 362908 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-02-25 12:15:59 PST 
Comment on attachment 362908 [details]
Patch

Clearing flags on attachment: 362908

Committed r242054: <https://trac.webkit.org/changeset/242054>
Comment 5 WebKit Commit Bot 2019-02-25 12:16:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-25 12:16:34 PST 
<rdar://problem/48372417>