Bug 194929 - Web Inspector: propagate whether to show prototype information to subobject views
Summary: Web Inspector: propagate whether to show prototype information to subobject v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 198721
  Show dependency tree / graph
 
Reported: 2019-02-21 19:31 PST by Devin Rousso
Modified: 2019-07-02 18:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2019-06-01 13:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-21 19:31:28 PST 
`_includeProtoProperty` is only set on the top-level `WI.ObjectTreeView`, not any of the child `WI.ObjectTreeBaseTreeElement`.  As a result, we see "Object prototype" for logs like `{a: {b: {c: 42}}}`.
Comment 1 Devin Rousso 2019-06-01 13:05:48 PDT 
Created attachment 371122 [details]
Patch
Comment 2 Matt Baker 2019-06-02 16:03:58 PDT 
Comment on attachment 371122 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-06-02 16:34:41 PDT 
Comment on attachment 371122 [details]
Patch

Clearing flags on attachment: 371122

Committed r246025: <https://trac.webkit.org/changeset/246025>
Comment 4 WebKit Commit Bot 2019-06-02 16:34:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-06-02 16:35:39 PDT 
<rdar://problem/51342180>