Bug 194927 – NetworkDataTask redirection should not keep alive its NetworkSession

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

NetworkDataTask redirection should not keep alive its NetworkSession

[Alex Christensen]

Created attachment 362680 [details]
Patch

[Darin Adler]

Comment on attachment 362680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362680&action=review

> Source/WebKit/NetworkProcess/NetworkDataTask.h:80
> +class NetworkDataTask : public RefCounted<NetworkDataTask>, CanMakeWeakPtr<NetworkDataTask> {

Need protected or public on CanMakeWeakPtr so it can be used in a class derived from this one. Or could put CanMakeWeakPtr on NetworkDataTaskCocoa instead.

[Alex Christensen]

Created attachment 362732 [details]
Patch

[EWS Watchlist]

Comment on attachment 362732 [details]
Patch

Attachment 362732 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11250465

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

[EWS Watchlist]

Created attachment 362763 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Alex Christensen]

http://trac.webkit.org/r242304

[Radar WebKit Bug Importer]

<rdar://problem/48531046>