Bug 194919 - webkitpy: Forward HOME to XPC processes
Summary: webkitpy: Forward HOME to XPC processes
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-21 14:11 PST by Jonathan Bedard
Modified: 2019-03-07 14:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2019-02-21 14:15 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-02-21 14:11:57 PST 
I think we should be forwarding the HOME environment variable child XPC processes, although I need to do a bit more testing to verify.
Comment 1 Jonathan Bedard 2019-02-21 14:12:41 PST 
<rdar://problem/48135951>
Comment 2 Jonathan Bedard 2019-02-21 14:15:55 PST 
Created attachment 362643 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-02-21 15:30:52 PST 
Comment on attachment 362643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362643&action=review

> Tools/Scripts/webkitpy/port/driver.py:415
> +        environment['__XPC_HOME'] = environment.get('HOME')

I don't understand why this became necessary now.

Did you reproduce the problem, and see it fixed with this change? Even if so, we probably need better understanding of the problem than what I saw documented yet.
Comment 4 Jonathan Bedard 2019-02-21 16:40:13 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 362643 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362643&action=review
> 
> > Tools/Scripts/webkitpy/port/driver.py:415
> > +        environment['__XPC_HOME'] = environment.get('HOME')
> 
> I don't understand why this became necessary now.
> 
> Did you reproduce the problem, and see it fixed with this change? Even if
> so, we probably need better understanding of the problem than what I saw
> documented yet.

Sorry, no, I have not yet been able to reproduce the problem. I just wanted to draft the patch, I didn't intend to put it up for review yet, actually.
Comment 5 Jonathan Bedard 2019-03-07 14:14:37 PST 
Upon further investigation, this change is not needed. Closing this bug.