Bug 194916 - fast/mediastream/MediaStream-video-element.html is flaky
Summary: fast/mediastream/MediaStream-video-element.html is flaky
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-21 13:51 PST by Chris Dumez
Modified: 2019-04-19 22:12 PDT (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-02-21 13:51:39 PST
fast/mediastream/MediaStream-video-element.html is flaky:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/mediastream/MediaStream-video-element-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/fast/mediastream/MediaStream-video-element-actual.txt
@@ -47,7 +47,7 @@
 video.audioTracks[0] properties:
   track.id = <UUID>
   track.kind = main
-  track.label = Mock audio device 1
+  track.label = 
   track.language = 
   track.enabled = true
   track.sourceBuffer = null

Steps to reproduce:
run-webkit-tests fast/mediastream/MediaStream-video-element-video-tracks-disabled.html fast/mediastream/MediaStream-video-element.html --child-processes 1
Comment 1 Chris Dumez 2019-02-21 13:52:55 PST
This is somehow related to using a different WebView for the 2 tests but the same WKContext/WebProcessPool. I am not super familiar with this code. I spent some time trying to understand the mock media devices code yesterday but could not figure out the issue.
Comment 2 Chris Dumez 2019-02-21 13:54:08 PST
This started with https://trac.webkit.org/changeset/241821 which avoids re-constructing a new WKContext / WebProcessPool between tests whenever possible.
Comment 3 Radar WebKit Bug Importer 2019-02-24 08:41:14 PST
<rdar://problem/48345402>
Comment 4 Truitt Savell 2019-02-25 09:05:07 PST
Marked test as failing to get the tree green while waiting on resolution:
https://trac.webkit.org/changeset/242044/webkit
Comment 5 Chris Dumez 2019-03-21 14:27:28 PDT
You can reproduce it with the test by itself:
Tools/Scripts/run-webkit-tests fast/mediastream/MediaStream-video-element.html -gf --repeat-each=50

So it is a flaky test and r241821 merely impacted the timing of things, making the test flakier.
Comment 6 Chris Dumez 2019-03-21 14:28:58 PDT
The test is relying on a setTimeout(100):

function canplay()
{
    debug("<br>*** start playback ****");
    evalAndLog("video.play()");
    setTimeout(checkVideoElement, 100);
}

:/
Comment 7 Ryosuke Niwa 2019-04-19 22:12:48 PDT
This test appears to be always failing now?รท