Bug 194915 - Update some media logging
Summary: Update some media logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-21 13:18 PST by Eric Carlson
Modified: 2019-02-22 07:45 PST (History)
7 users (show)

See Also:

Attachments
Patch (15.24 KB, patch)
2019-02-21 13:30 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-02-21 13:18:35 PST 
Clean up some media logging.
Comment 1 Eric Carlson 2019-02-21 13:30:12 PST 
Created attachment 362639 [details]
Patch
Comment 2 EWS Watchlist 2019-02-21 13:33:06 PST 
Attachment 362639 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaElementSession.cpp:988:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2019-02-22 05:52:24 PST 
Comment on attachment 362639 [details]
Patch

Clearing flags on attachment: 362639

Committed r241945: <https://trac.webkit.org/changeset/241945>
Comment 4 WebKit Commit Bot 2019-02-22 05:52:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-22 07:45:01 PST 
<rdar://problem/48311310>