Bug 194885 – Web Inspector: macOS user agent option should be available in device settings menu

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Since this menu only appears on remote targets, they might want to set the user agent to a desktop one to test something.

[Radar WebKit Bug Importer]

<rdar://problem/48259253>

[Devin Rousso]

Created attachment 362586 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 362586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:2074
> +            { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" },

I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are.

> Source/WebInspectorUI/UserInterface/Base/Main.js:2076
> +        ],
>          [

Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad.
We could even consider a watchOS UserAgent.

[Devin Rousso]

Comment on attachment 362586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:2074
>> +            { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" },
> 
> I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are.

I got this from the most recent developer beta.  One annoying thing about this is that we're going to have to update this (and the others) when the system updates.  Perhaps we can add something to `InpsectorFrontendHost`.

>> Source/WebInspectorUI/UserInterface/Base/Main.js:2076
>>          [
> 
> Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad.
> We could even consider a watchOS UserAgent.

This matches the current develop menu's structure.

[WebKit Commit Bot]

Comment on attachment 362586 [details]
Patch

Clearing flags on attachment: 362586

Committed r241870: <https://trac.webkit.org/changeset/241870>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.