Bug 194885 - Web Inspector: macOS user agent option should be available in device settings menu
Summary: Web Inspector: macOS user agent option should be available in device settings...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-20 17:07 PST by Devin Rousso
Modified: 2019-02-21 10:00 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2019-02-20 20:59 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-20 17:07:22 PST
Since this menu only appears on remote targets, they might want to set the user agent to a desktop one to test something.
Comment 1 Radar WebKit Bug Importer 2019-02-20 17:25:33 PST
<rdar://problem/48259253>
Comment 2 Devin Rousso 2019-02-20 20:59:32 PST
Created attachment 362586 [details]
Patch
Comment 3 Joseph Pecoraro 2019-02-20 21:28:24 PST
Comment on attachment 362586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:2074
> +            { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" },

I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are.

> Source/WebInspectorUI/UserInterface/Base/Main.js:2076
> +        ],
>          [

Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad.
We could even consider a watchOS UserAgent.
Comment 4 Devin Rousso 2019-02-21 09:35:29 PST
Comment on attachment 362586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review

>> Source/WebInspectorUI/UserInterface/Base/Main.js:2074
>> +            { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" },
> 
> I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are.

I got this from the most recent developer beta.  One annoying thing about this is that we're going to have to update this (and the others) when the system updates.  Perhaps we can add something to `InpsectorFrontendHost`.

>> Source/WebInspectorUI/UserInterface/Base/Main.js:2076
>>          [
> 
> Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad.
> We could even consider a watchOS UserAgent.

This matches the current develop menu's structure.
Comment 5 WebKit Commit Bot 2019-02-21 10:00:55 PST
Comment on attachment 362586 [details]
Patch

Clearing flags on attachment: 362586

Committed r241870: <https://trac.webkit.org/changeset/241870>
Comment 6 WebKit Commit Bot 2019-02-21 10:00:56 PST
All reviewed patches have been landed.  Closing bug.