Bug 194883 – Web Inspector: eliminate manual syncing of numeric constants used by JavaScript and CSS

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Summary:
Eliminate manual syncing of numeric constants used by JavaScript and CSS.

Web Inspector CSS occasionally uses numeric constants that must also be available to code. Currently we rely on the developer to keep the JavaScript and CSS worlds in sync. These custom properties should have their values set by Web Inspector code so that can't get out of sync.

Note:
The CSS custom property `--recording-auto-capture-input-margin` in CanvasOverviewContentView.css has already become out of sync. Let's fix this!

[Radar WebKit Bug Importer]

<rdar://problem/48257785>

[Devin Rousso]

Created attachment 364220 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 364220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364220&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:117
> +    static get _memoryCategoryViewheight() { return 75; }

Typo: "...Viewheight" => "...ViewHeight"

I also really dislike _ prefixed getters. They are very confusing / unexpected to work work and this is a constant that doesn't need to be "private".

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:119
> +.network-table .cell.name > .status {
> +    -webkit-margin-left: 4px;
> +}

Seems like this should be `-webkit-margin-start` not `-webkit-margin-left`.

The sync changes and the -webkit-margin changes should really be different patches. They are almost entirely unrelated changes each with their own possibility of causing regressions.

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:201
> +    static get _nodeWaterfallDOMEventSize() { return 8; }

Same, this doesn't need to be underscore prefixed.

[Devin Rousso]

Created attachment 364280 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 364280 [details]
Patch

Clearing flags on attachment: 364280

Committed r242737: <https://trac.webkit.org/changeset/242737>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.