Bug 194881 - [PSON] Make sure hung processes are not kept alive by suspended pages or process caching
Summary: [PSON] Make sure hung processes are not kept alive by suspended pages or proc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-20 16:12 PST by Chris Dumez
Modified: 2019-02-21 15:59 PST (History)
6 users (show)

See Also:


Attachments
Patch (12.39 KB, patch)
2019-02-20 16:19 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-02-20 16:12:22 PST
Make sure hung processes are not kept alive by suspended pages or process caching.
Comment 1 Chris Dumez 2019-02-20 16:12:36 PST
<rdar://problem/48249014>
Comment 2 Chris Dumez 2019-02-20 16:19:21 PST
Created attachment 362564 [details]
Patch
Comment 3 Ryosuke Niwa 2019-02-20 16:25:46 PST
Comment on attachment 362564 [details]
Patch

Is it possible for the process to start using a lot of CPU after it had entered the cache?
Maybe we need to kill those processes retroactively as well?
Comment 4 Geoffrey Garen 2019-02-20 16:27:39 PST
Comment on attachment 362564 [details]
Patch

r=me
Comment 5 Chris Dumez 2019-02-20 16:28:24 PST
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 362564 [details]
> Patch
> 
> Is it possible for the process to start using a lot of CPU after it had
> entered the cache?
> Maybe we need to kill those processes retroactively as well?

I do not think this is possible, such processes have no WebPages anymore. Running JS is normally the issue.
Comment 6 WebKit Commit Bot 2019-02-20 17:25:52 PST
Comment on attachment 362564 [details]
Patch

Clearing flags on attachment: 362564

Committed r241855: <https://trac.webkit.org/changeset/241855>
Comment 7 WebKit Commit Bot 2019-02-20 17:25:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Chris Dumez 2019-02-21 09:25:17 PST
Follow-up fix for API tests in <https://trac.webkit.org/changeset/241868>.
Comment 9 Chris Dumez 2019-02-21 15:59:51 PST
Another follow-up fix:
<https://trac.webkit.org/changeset/241919>