Bug 194879 – [CMake][Win] Fix !USE(CF) build of WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Don Olmstead]

Currently the PlatformWin files for WebCore do not allow for compilation of WebCore without CF.

[Don Olmstead]

Created attachment 362562 [details]
Patch

[Konstantin Tokarev]

Comment on attachment 362562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362562&action=review

> Source/WebCore/editing/SmartReplaceCF.cpp:32
> +#if USE(CF)

This #if duplicates cmake condition which enables compilation of this file only when USE_CF is true

[Don Olmstead]

(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 362562 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362562&action=review
> 
> > Source/WebCore/editing/SmartReplaceCF.cpp:32
> > +#if USE(CF)
> 
> This #if duplicates cmake condition which enables compilation of this file
> only when USE_CF is true

We aren't really consistent with #if USE guards. I can remove it or keep it there. Its fine either way.

[EWS Watchlist]

Comment on attachment 362562 [details]
Patch

Attachment 362562 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11226487

New failing tests:
fast/forms/number/number-l10n-input.html

[EWS Watchlist]

Created attachment 362582 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Don Olmstead]

Created attachment 362615 [details]
Patch

Removing the #if guards in the SmartReplaceCF.cpp.

[EWS Watchlist]

Comment on attachment 362615 [details]
Patch

Attachment 362615 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11233692

New failing tests:
fast/forms/number/number-l10n-input.html

[EWS Watchlist]

Created attachment 362621 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Don Olmstead]

Created attachment 362623 [details]
Patch

Fix AppleWin tests.

[WebKit Commit Bot]

Comment on attachment 362623 [details]
Patch

Clearing flags on attachment: 362623

Committed r241876: <https://trac.webkit.org/changeset/241876>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.