Bug 194879 - [CMake][Win] Fix !USE(CF) build of WebCore
Summary: [CMake][Win] Fix !USE(CF) build of WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks: 175336
  Show dependency treegraph
 
Reported: 2019-02-20 16:05 PST by Don Olmstead
Modified: 2019-02-21 13:06 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.34 KB, patch)
2019-02-20 16:11 PST, Don Olmstead
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.88 MB, application/zip)
2019-02-20 18:49 PST, Build Bot
no flags Details
Patch (2.75 KB, patch)
2019-02-21 09:28 PST, Don Olmstead
annulen: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (12.83 MB, application/zip)
2019-02-21 11:15 PST, Build Bot
no flags Details
Patch (3.06 KB, patch)
2019-02-21 11:29 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-02-20 16:05:00 PST
Currently the PlatformWin files for WebCore do not allow for compilation of WebCore without CF.
Comment 1 Don Olmstead 2019-02-20 16:11:45 PST
Created attachment 362562 [details]
Patch
Comment 2 Konstantin Tokarev 2019-02-20 16:15:16 PST
Comment on attachment 362562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362562&action=review

> Source/WebCore/editing/SmartReplaceCF.cpp:32
> +#if USE(CF)

This #if duplicates cmake condition which enables compilation of this file only when USE_CF is true
Comment 3 Don Olmstead 2019-02-20 16:20:07 PST
(In reply to Konstantin Tokarev from comment #2)
> Comment on attachment 362562 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362562&action=review
> 
> > Source/WebCore/editing/SmartReplaceCF.cpp:32
> > +#if USE(CF)
> 
> This #if duplicates cmake condition which enables compilation of this file
> only when USE_CF is true

We aren't really consistent with #if USE guards. I can remove it or keep it there. Its fine either way.
Comment 4 Build Bot 2019-02-20 18:48:55 PST
Comment on attachment 362562 [details]
Patch

Attachment 362562 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11226487

New failing tests:
fast/forms/number/number-l10n-input.html
Comment 5 Build Bot 2019-02-20 18:49:07 PST
Created attachment 362582 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 6 Don Olmstead 2019-02-21 09:28:06 PST
Created attachment 362615 [details]
Patch

Removing the #if guards in the SmartReplaceCF.cpp.
Comment 7 Build Bot 2019-02-21 11:15:13 PST
Comment on attachment 362615 [details]
Patch

Attachment 362615 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11233692

New failing tests:
fast/forms/number/number-l10n-input.html
Comment 8 Build Bot 2019-02-21 11:15:24 PST
Created attachment 362621 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 9 Don Olmstead 2019-02-21 11:29:57 PST
Created attachment 362623 [details]
Patch

Fix AppleWin tests.
Comment 10 WebKit Commit Bot 2019-02-21 13:06:42 PST
Comment on attachment 362623 [details]
Patch

Clearing flags on attachment: 362623

Committed r241876: <https://trac.webkit.org/changeset/241876>
Comment 11 WebKit Commit Bot 2019-02-21 13:06:44 PST
All reviewed patches have been landed.  Closing bug.