Bug 194878 - Rotation animations sometimes use the wrong origin (affects apple.com)
Summary: Rotation animations sometimes use the wrong origin (affects apple.com)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-20 16:02 PST by Dean Jackson
Modified: 2019-02-22 17:28 PST (History)
9 users (show)

See Also:


Attachments
Patch (34.18 KB, patch)
2019-02-20 16:10 PST, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-02-20 16:02:33 PST
Rotation animations sometimes use the wrong origin (affects apple.com)
Comment 1 Dean Jackson 2019-02-20 16:05:03 PST
<rdar://problem/43908047>
Comment 2 Dean Jackson 2019-02-20 16:10:36 PST
Created attachment 362560 [details]
Patch
Comment 3 Dean Jackson 2019-02-20 16:49:53 PST
Committed r241852: <https://trac.webkit.org/changeset/241852>
Comment 4 Antoine Quint 2019-02-21 02:32:39 PST
Why is there no version check for iOS? Has this behaviour always existed on iOS?
Comment 5 Dean Jackson 2019-02-21 09:02:43 PST
(In reply to Antoine Quint from comment #4)
> Why is there no version check for iOS? Has this behaviour always existed on
> iOS?

You're right that this hasn't changed for iOS yet, but ToT is already targeting the future.
Comment 6 Antoine Quint 2019-02-21 09:36:01 PST
(In reply to Dean Jackson from comment #5)
> (In reply to Antoine Quint from comment #4)
> > Why is there no version check for iOS? Has this behaviour always existed on
> > iOS?
> 
> You're right that this hasn't changed for iOS yet, but ToT is already
> targeting the future.

Should we address that? Bots and anyone building for iOS with OpenSource will have the wrong behaviour.
Comment 7 Simon Fraser (smfr) 2019-02-21 11:04:21 PST
(In reply to Antoine Quint from comment #6)
> (In reply to Dean Jackson from comment #5)
> > (In reply to Antoine Quint from comment #4)
> > > Why is there no version check for iOS? Has this behaviour always existed on
> > > iOS?
> > 
> > You're right that this hasn't changed for iOS yet, but ToT is already
> > targeting the future.
> 
> Should we address that? Bots and anyone building for iOS with OpenSource
> will have the wrong behaviour.

Yes, we need to maintain correct behavior when running on iOS 12.
Comment 8 Shawn Roberts 2019-02-22 17:27:56 PST
Test is showing missing results in dashboard.

Flakiness Dashboard :

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Fanimations%2Fadditive-transform-animations.html

Started with r241852 . Appears that expected file might be missing.