Bug 194876 - [Win] Remove CF when using Windows clipboard
Summary: [Win] Remove CF when using Windows clipboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 175336
  Show dependency tree / graph
 
Reported: 2019-02-20 15:32 PST by Don Olmstead
Modified: 2021-12-08 16:34 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2021-12-08 14:25 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-02-20 15:32:21 PST 
ClipboardUtilitiesWin.cpp DragDataWin.cpp and PasteboardWin.cpp all have USE(CF) guards which have minimal requirements on CF.

Need to replace urlFromPath within ClipboardUtilitiesWin and then all the guards can be removed completely.
Comment 1 Don Olmstead 2021-12-08 14:25:20 PST 
Created attachment 446420 [details]
Patch
Comment 2 Brent Fulgham 2021-12-08 14:43:03 PST 
Comment on attachment 446420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446420&action=review

r=me

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:468
> +                url = URL::fileURLWithFileSystemPath(String(data)).fileSystemPath();

Very nice!
Comment 3 EWS 2021-12-08 16:33:23 PST 
Committed r286752 (244995@main): <https://commits.webkit.org/244995@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446420 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-08 16:34:20 PST 
<rdar://problem/86240474>