Bug 194874 - Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation
Summary: Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-20 15:00 PST by Devin Rousso
Modified: 2019-02-21 10:56 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2019-02-20 15:33 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-02-20 15:00:09 PST 
# STEPS TO REPRODUCE:
1. inspect any page
2. find a node with an event listener
3. set a breakpoint on that specific event listener via Node sidebar in Elements tab
4. go to the Debugger tab
5. reload/navigate the page
 => breakpoint for that specific event is still listed in the navigation sidebar
Comment 1 Radar WebKit Bug Importer 2019-02-20 15:01:33 PST 
<rdar://problem/48253415>
Comment 2 Devin Rousso 2019-02-20 15:11:33 PST 
(In reply to Devin Rousso from comment #0)
>  => breakpoint for that specific event is still listed in the navigation sidebar
Interestingly, these "still listed" breakpoints are unable to be removed.  

DOMManager.js:645:23: CONSOLE ERROR
DOMManager.js:651:30: CONSOLE ERROR No event listener for given identifier.
Comment 3 Devin Rousso 2019-02-20 15:33:32 PST 
Created attachment 362554 [details]
Patch
Comment 4 Joseph Pecoraro 2019-02-21 10:18:50 PST 
Comment on attachment 362554 [details]
Patch

r=me
Comment 5 Joseph Pecoraro 2019-02-21 10:19:42 PST 
You could probably write a test for this by setting an EventListener Breakpoint, reloading, and ensuring it is gone.
Comment 6 Devin Rousso 2019-02-21 10:29:40 PST 
(In reply to Joseph Pecoraro from comment #5)
> You could probably write a test for this by setting an EventListener Breakpoint, reloading, and ensuring it is gone.
I titled this bug slightly "overzealously".  The EventListener Breakpoints were being cleared successfully (e.g. backend state is cleared), but the weren't getting removed from the UI.
Comment 7 WebKit Commit Bot 2019-02-21 10:56:41 PST 
Comment on attachment 362554 [details]
Patch

Clearing flags on attachment: 362554

Committed r241874: <https://trac.webkit.org/changeset/241874>
Comment 8 WebKit Commit Bot 2019-02-21 10:56:43 PST 
All reviewed patches have been landed.  Closing bug.