Bug 194874 – Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE:
1. inspect any page
2. find a node with an event listener
3. set a breakpoint on that specific event listener via Node sidebar in Elements tab
4. go to the Debugger tab
5. reload/navigate the page
 => breakpoint for that specific event is still listed in the navigation sidebar

[Radar WebKit Bug Importer]

<rdar://problem/48253415>

[Devin Rousso]

(In reply to Devin Rousso from comment #0)
>  => breakpoint for that specific event is still listed in the navigation sidebar
Interestingly, these "still listed" breakpoints are unable to be removed.  

DOMManager.js:645:23: CONSOLE ERROR
DOMManager.js:651:30: CONSOLE ERROR No event listener for given identifier.

[Devin Rousso]

Created attachment 362554 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 362554 [details]
Patch

r=me

[Joseph Pecoraro]

You could probably write a test for this by setting an EventListener Breakpoint, reloading, and ensuring it is gone.

[Devin Rousso]

(In reply to Joseph Pecoraro from comment #5)
> You could probably write a test for this by setting an EventListener Breakpoint, reloading, and ensuring it is gone.
I titled this bug slightly "overzealously".  The EventListener Breakpoints were being cleared successfully (e.g. backend state is cleared), but the weren't getting removed from the UI.

[WebKit Commit Bot]

Comment on attachment 362554 [details]
Patch

Clearing flags on attachment: 362554

Committed r241874: <https://trac.webkit.org/changeset/241874>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.