Bug 194853 – [JSC][x86] Drop support for x87 floating point

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Xan Lopez]

A x86/32bit build (see bug #194147) fails a number of stress tests because of one-off rounding errors in floating point operations. This is caused by the use of extended precision FP registers, which is what x87 does unless told otherwise. We can work around this in a number of ways: forcing SSE2 for x86 at build time, forcing the use of double precision registers in x87, etc. After some digging up, though, it was noticed that other browsers are increasing their minimum requirements for intel hardware to pentium4/SSE2, as:

* Firefox: https://support.mozilla.org/en-US/kb/your-hardware-no-longer-supported
* Chrome: https://support.google.com/chrome/a/answer/7100626?hl=en

This simplifies our code, and intel hardware without SSE2 is in practice extremely rare. The following patch assumes SSE2 throughout the codebase, removes x87 support in certain places, and gets rid of a few obsolete comments. I have left in place SSE2 detection in MacroAssemblerX86 class, and required it through a static_assert. It's just a few lines of C++ code and it seems much easier than adding a lot of new CMake code to do the same thing.

[Xan Lopez]

Created attachment 362490 [details]
Drop x87 support

[Caio Lima]

Comment on attachment 362490 [details]
Drop x87 support

LGTM. I wonder what EWS thinks about it.

[Xan Lopez]

Created attachment 362491 [details]
Drop x87 support

[Xan Lopez]

Created attachment 362492 [details]
Drop x87 support

[Keith Miller]

Comment on attachment 362492 [details]
Drop x87 support

r=me. Can we make sure no one else wants this on webkit-dev before landing though?

[Xan Lopez]

(In reply to Keith Miller from comment #5)
> Comment on attachment 362492 [details]
> Drop x87 support
> 
> r=me. Can we make sure no one else wants this on webkit-dev before landing
> though?

Sent the email, let's see: https://lists.webkit.org/pipermail/webkit-dev/2019-March/030529.html

[Don Olmstead]

WinCairo can technically build in 32-bit mode but we don't provide that anyways. Minimum install for Windows definitely requires a PC with SSE2 support so we're fine with this. PlayStation is x64 so again no problem.

Will let someone from the AppleWin side chime in here but honestly it doesn't seem like an issue.

[Xan Lopez]

Created attachment 365539 [details]
Drop x87 support

Seems nobody has anything against this, so let's do it. Patch rebased against master.

[Don Olmstead]

Comment on attachment 365539 [details]
Drop x87 support

Xan in the future after you get a r+ you can just replace the NOBODY (OOPS!) and just ask for a cq+ or if you're a committer just commit it.

[WebKit Commit Bot]

Comment on attachment 365539 [details]
Drop x87 support

Clearing flags on attachment: 365539

Committed r243293: <https://trac.webkit.org/changeset/243293>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49109764>

(In reply to Don Olmstead from comment #7)
> WinCairo can technically build in 32-bit mode but we don't provide that
> anyways. Minimum install for Windows definitely requires a PC with SSE2
> support so we're fine with this. PlayStation is x64 so again no problem.
> 
> Will let someone from the AppleWin side chime in here but honestly it
> doesn't seem like an issue.

Except one thing: AMD Athlon XP processors on Linux are now cannot start the browser at all. I was using GNOME Web (epiphany-browser) on Lubuntu 18 until the latest WebKitGTK update, but since this SSE2 requirement, my computer became unable to use WebKit. So, this is an issue for me. It was working fine without SSE2, pages using JavaScript heavily (like agar.io and slither.io) and even YouTube videos worked just fine.

About one year ago I fixed the hardcoded SSE2 requirement, and it was working great until now.

Here I fixed the dependency on SSE2 last year (now it is a problem again):
https://bugs.webkit.org/show_bug.cgi?id=188145

[Yusuke Suzuki]

(In reply to karogyoker2+webkit from comment #13)
> (In reply to Don Olmstead from comment #7)
> > WinCairo can technically build in 32-bit mode but we don't provide that
> > anyways. Minimum install for Windows definitely requires a PC with SSE2
> > support so we're fine with this. PlayStation is x64 so again no problem.
> > 
> > Will let someone from the AppleWin side chime in here but honestly it
> > doesn't seem like an issue.
> 
> Except one thing: AMD Athlon XP processors on Linux are now cannot start the
> browser at all. I was using GNOME Web (epiphany-browser) on Lubuntu 18 until
> the latest WebKitGTK update, but since this SSE2 requirement, my computer
> became unable to use WebKit. So, this is an issue for me. It was working
> fine without SSE2, pages using JavaScript heavily (like agar.io and
> slither.io) and even YouTube videos worked just fine.
> 
> About one year ago I fixed the hardcoded SSE2 requirement, and it was
> working great until now.
> 
> Here I fixed the dependency on SSE2 last year (now it is a problem again):
> https://bugs.webkit.org/show_bug.cgi?id=188145

We decide we no longer support it.
https://lists.webkit.org/pipermail/webkit-dev/2019-March/030569.html