Bug 194841 - [MSVC] Fix compilation errors with lambdas in Service Workers
Summary: [MSVC] Fix compilation errors with lambdas in Service Workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-19 16:24 PST by Don Olmstead
Modified: 2019-02-20 10:52 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2019-02-19 17:04 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2019-02-19 16:24:54 PST 
There are some issues around compiling Service Workers on Windows around lambdas and some declarations.
Comment 1 Don Olmstead 2019-02-19 17:04:27 PST 
Created attachment 362454 [details]
Patch
Comment 2 Alex Christensen 2019-02-20 10:16:54 PST 
Comment on attachment 362454 [details]
Patch

r=me, even though they claim to have fixed this in a future version of MSVC
Comment 3 Don Olmstead 2019-02-20 10:18:48 PST 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 362454 [details]
> Patch
> 
> r=me, even though they claim to have fixed this in a future version of MSVC

They haven't. This is compiled using Visual Studio 2019 Preview 3.
Comment 4 WebKit Commit Bot 2019-02-20 10:23:26 PST 
Comment on attachment 362454 [details]
Patch

Clearing flags on attachment: 362454

Committed r241820: <https://trac.webkit.org/changeset/241820>
Comment 5 WebKit Commit Bot 2019-02-20 10:23:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-20 10:52:41 PST 
<rdar://problem/48243297>