Bug 194836 – [bmalloc] bmalloc::Heap is allocated even though we use system malloc mode

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[Yusuke Suzuki]

...

[Yusuke Suzuki]

Created attachment 362481 [details]
Patch

[Yusuke Suzuki]

Created attachment 362482 [details]
Patch

[Mark Lam]

Comment on attachment 362482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362482&action=review

r=me.  Can you run PerformanceTests/MallocBench just to be sure that there's no significant perf difference?

> Source/bmalloc/bmalloc/bmalloc.cpp:71
> +        {
> +            std::unique_lock<Mutex> lock(Heap::mutex());
> +            result = heap.tryAllocateLarge(lock, alignment, size);
> +            if (result) {
> +                // Don't track this as dirty memory that dictates how we drive the scavenger.
> +                // FIXME: We should make it so that users of this API inform bmalloc which
> +                // pages they dirty:
> +                // https://bugs.webkit.org/show_bug.cgi?id=184207
> +                heap.externalDecommit(lock, result, size);
> +            }
>          }

No need to indent one more level here.  You're already inside a scope unlike before.

[Yusuke Suzuki]

Comment on attachment 362482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362482&action=review

I ran MallocBench and it was performance neutral.

>> Source/bmalloc/bmalloc/bmalloc.cpp:71
>>          }
> 
> No need to indent one more level here.  You're already inside a scope unlike before.

Fixed, thanks.

[Yusuke Suzuki]

Committed r241847: <https://trac.webkit.org/changeset/241847>

[Radar WebKit Bug Importer]

<rdar://problem/48256231>