RESOLVED FIXED 194835
Reduce use of LegacySync IPC message type 
https://bugs.webkit.org/show_bug.cgi?id=194835
Summary Reduce use of LegacySync IPC message type
Alex Christensen
Reported 2019-02-19 15:24:52 PST
Reduce use of LegacySync IPC message type
Attachments
Patch (41.53 KB, patch)
2019-02-19 15:27 PST, Alex Christensen 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-02-19 15:27:56 PST
Created attachment 362444 [details] Patch
Darin Adler
Comment 2 2019-02-21 19:22:39 PST
Comment on attachment 362444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362444&action=review > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:464 > + completionHandler(result.first, result.second); I think WTFMove(result.first) would save a tiny bit of reference count churn. > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:487 > + completionHandler(result.first, result.second); I think WTFMove(result.first) would save a tiny bit of reference count churn. > Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:254 > + return completionHandler(false); There it is, one of those return void things. > Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:261 > + completionHandler(true); But no return here. What about if you refactor and add a return value? (Just kidding.)
Alex Christensen
Comment 3 2019-03-20 16:38:08 PDT
http://trac.webkit.org/r243258
Radar WebKit Bug Importer
Comment 4 2019-03-20 16:43:21 PDT
<rdar://problem/49085284>
Note You need to log in before you can comment on or make changes to this bug.