Bug 194835 - Reduce use of LegacySync IPC message type
Summary: Reduce use of LegacySync IPC message type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-19 15:24 PST by Alex Christensen
Modified: 2019-03-20 16:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (41.53 KB, patch)
2019-02-19 15:27 PST, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-02-19 15:24:52 PST 
Reduce use of LegacySync IPC message type
Comment 1 Alex Christensen 2019-02-19 15:27:56 PST 
Created attachment 362444 [details]
Patch
Comment 2 Darin Adler 2019-02-21 19:22:39 PST 
Comment on attachment 362444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362444&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:464
> +    completionHandler(result.first, result.second);

I think WTFMove(result.first) would save a tiny bit of reference count churn.

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:487
> +    completionHandler(result.first, result.second);

I think WTFMove(result.first) would save a tiny bit of reference count churn.

> Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:254
> +        return completionHandler(false);

There it is, one of those return void things.

> Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:261
> +    completionHandler(true);

But no return here. What about if you refactor and add a return value? (Just kidding.)
Comment 3 Alex Christensen 2019-03-20 16:38:08 PDT 
http://trac.webkit.org/r243258
Comment 4 Radar WebKit Bug Importer 2019-03-20 16:43:21 PDT 
<rdar://problem/49085284>