Bug 194831 - CachedCall should not consider it UNLIKELY that it will not stack overflow
Summary: CachedCall should not consider it UNLIKELY that it will not stack overflow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-19 14:54 PST by Robin Morisset
Modified: 2019-02-19 15:18 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.44 KB, patch)
2019-02-19 14:56 PST, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-02-19 14:54:11 PST
if (UNLIKELY(vm.isSafeToRecurseSoft())) {

in CachedCall.h is absurd: running out of stack is not likely.
Comment 1 Robin Morisset 2019-02-19 14:56:03 PST
Created attachment 362438 [details]
Patch
Comment 2 Mark Lam 2019-02-19 15:00:01 PST
Comment on attachment 362438 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-02-19 15:17:22 PST
Comment on attachment 362438 [details]
Patch

Clearing flags on attachment: 362438

Committed r241781: <https://trac.webkit.org/changeset/241781>
Comment 4 WebKit Commit Bot 2019-02-19 15:17:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-02-19 15:18:36 PST
<rdar://problem/48217244>