Bug 194816 – test262-runner ends with SIGPIPE signal

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Diego Pino]

In certain environments when running `test262-runner` the program ends abruptly with a SIGPIPE signal. Example:

```
$ Tools/Scripts/test262-runner --release

Settings:
Test262 Dir: JSTests/test262
JSC: WebKitBuild/Release/bin/jsc
Child Processes: 256
DYLD_FRAMEWORK_PATH: /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/bin
Config file: JSTests/test262/config.yaml
Expectations file: JSTests/test262/expectations.yaml
---

$ echo $?
141
```

This is inconvenient because `test262-runner` ends without printing out tests summary results.

By certain environments I mean the issue always happens in one specific host, while I have no issues in a different host.

[Diego Pino]

Created attachment 362382 [details]
Patch

[Diego Pino]

Explanation of the patch.

I debugged the issue using 'Carp::Trace'. I captured SIGPIPE signals and printed out a trace. I got the following output:

```
Test262::Runner::main [3]
        scalar - new stash
        /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 122
Test262::Runner::(eval) [2]
        scalar - no new stash
        /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 416
Test262::Runner::__ANON__ [1]
        scalar - new stash
        /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 416
```

This pattern occurred several times in the output.

IIRC, a SIGPIPE happens when attempting to write on a closed pipe. In the case of the suspecting line (416), I think what is happening if that child is trying to write on a closed socket (the parent was closed right before that loop). In any case, it seems to me this block of code is redundant, so I removed it.

After applying the patch, `test262-runner --release` runs just fine (exit status is 0).

[Diego Pino]

Created attachment 384441 [details]
Patch

[Diego Pino]

Comment on attachment 384441 [details]
Patch

Carlos López reviewed the patch and granted r+ on private conversation.

[EWS]

Comment on attachment 384441 [details]
Patch

Rejecting attachment 384441 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 384441 [details]
Patch

Clearing flags on attachment: 384441

Committed r252930: <https://trac.webkit.org/changeset/252930>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57521420>