WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
194804
[LFC][Floats] Remove redundant intersecting logic
https://bugs.webkit.org/show_bug.cgi?id=194804
Summary
[LFC][Floats] Remove redundant intersecting logic
zalan
Reported
2019-02-18 18:41:19 PST
in FloatingPair::intersects
Attachments
Patch
(4.64 KB, patch)
2019-02-18 18:57 PST
,
zalan
koivisto
: review+
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2
(9.98 MB, application/zip)
2019-02-18 20:57 PST
,
EWS Watchlist
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2019-02-18 18:57:27 PST
Created
attachment 362363
[details]
Patch
EWS Watchlist
Comment 2
2019-02-18 20:57:21 PST
Comment on
attachment 362363
[details]
Patch
Attachment 362363
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
https://webkit-queues.webkit.org/results/11199819
New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
EWS Watchlist
Comment 3
2019-02-18 20:57:22 PST
Created
attachment 362366
[details]
Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
zalan
Comment 4
2019-02-18 21:01:44 PST
(In reply to Build Bot from
comment #2
)
> Comment on
attachment 362363
[details]
> Patch > >
Attachment 362363
[details]
did not pass ios-sim-ews (ios-simulator-wk2): > Output:
https://webkit-queues.webkit.org/results/11199819
> > New failing tests: > imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html
lol
Antti Koivisto
Comment 5
2019-02-19 13:00:26 PST
Comment on
attachment 362363
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=362363&action=review
> Source/WebCore/layout/floats/FloatingContext.cpp:325 > + return floating ? floating->rectWithMargin().intersects(floatAvoiderRect) : false;
return floating && floating->rectWithMargin().intersects(floatAvoiderRect);
Antti Koivisto
Comment 6
2019-02-19 13:00:53 PST
> > New failing tests: > > imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html > lol
🤣
zalan
Comment 7
2019-02-19 14:33:49 PST
Committed
r241774
: <
https://trac.webkit.org/changeset/241774
>
Radar WebKit Bug Importer
Comment 8
2019-02-19 14:34:31 PST
<
rdar://problem/48215395
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug