Bug 194776 - [iOS] Dispatch additional events along with pointerdown and pointerup
Summary: [iOS] Dispatch additional events along with pointerdown and pointerup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-18 07:56 PST by Antoine Quint
Modified: 2019-02-18 09:52 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.65 KB, patch)
2019-02-18 08:10 PST, Antoine Quint 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-02-18 07:56:15 PST 
The Pointer Events spec says that "pointerover" and "pointerenter" should precede the dispatch of "pointerdown" and that "pointerout" and "pointerleave" should follow the dispatch of "pointerup".
Comment 1 Radar WebKit Bug Importer 2019-02-18 07:56:39 PST 
<rdar://problem/48164284>
Comment 2 Antoine Quint 2019-02-18 08:10:09 PST 
Created attachment 362297 [details]
Patch
Comment 3 Brent Fulgham 2019-02-18 09:37:41 PST 
Comment on attachment 362297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362297&action=review

Seems reasonable. r=me

> Source/WebCore/page/PointerCaptureController.cpp:136
>  

I guess this needs to be protected by "#if ENABLE(TOUCH_EVENTS) && PLATFORM(IOS_FAMILY)"

> Source/WebCore/page/PointerCaptureController.cpp:-173
> -        

Whitespace.
Comment 4 Antoine Quint 2019-02-18 09:52:48 PST 
Committed r241723: <https://trac.webkit.org/changeset/241723>