Bug 194743 - [JSC] JSWrapperObject should not be destructible
Summary: [JSC] JSWrapperObject should not be destructible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-16 01:33 PST by Yusuke Suzuki
Modified: 2019-02-16 10:51 PST (History)
6 users (show)

See Also:

Attachments
Patch (20.31 KB, patch)
2019-02-16 01:54 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-02-16 01:33:26 PST 
[JSC] JSWrapperObject should not be destructible
Comment 1 Yusuke Suzuki 2019-02-16 01:54:59 PST 
Created attachment 362214 [details]
Patch
Comment 2 Saam Barati 2019-02-16 02:19:35 PST 
Comment on attachment 362214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362214&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        JSWrapperObjec to JSDestructibleObject, and makes JSWrapperObject non-destructible.

Typo: JSWrapperObjec
Comment 3 Yusuke Suzuki 2019-02-16 10:41:39 PST 
Comment on attachment 362214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362214&action=review

>> Source/JavaScriptCore/ChangeLog:10
>> +        JSWrapperObjec to JSDestructibleObject, and makes JSWrapperObject non-destructible.
> 
> Typo: JSWrapperObjec

Thanks, fixed!
Comment 4 Yusuke Suzuki 2019-02-16 10:50:18 PST 
Committed r241649: <https://trac.webkit.org/changeset/241649>
Comment 5 Radar WebKit Bug Importer 2019-02-16 10:51:23 PST 
<rdar://problem/48139806>